Conversation
Collaborator
|
Sweet - I am all for this. I've been watching the pip issue and was planning to do this once accepted. It's been verbally so I am happy to go this route too. |
cooperlees
approved these changes
Jun 4, 2021
Collaborator
cooperlees
left a comment
There was a problem hiding this comment.
Nice. LGTM especially with the test.toml being loaded with new syntax.
hukkin
reviewed
Jun 8, 2021
This was referenced Jun 22, 2021
Collaborator
|
While I agree with Hynek's article, if the maintainer of a library we want to use is explicitly asking us for an upper bound then I think we should respect that. Thanks for your work on tomli, @hukkin. |
e3603fa to
ec56588
Compare
toml unfortunately has a lack of maintainership issue right now. It's evident by the fact toml only supports TOML v0.5.0. TOML v1.0.0 has been recently released and right now Black crashes hard on its usage. tomli is a brand new parse only TOML library. It supports TOML v1.0.0. Although TBH we're switching to this one mostly because pip is doing the same. *The upper bound was included at the library maintainer's request. Co-authored-by: Łukasz Langa <lukasz@langa.pl> Co-authored-by: Taneli Hukkinen <3275109+hukkin@users.noreply.github.com>
ec56588 to
7e1acb7
Compare
JelleZijlstra
approved these changes
Jul 12, 2021
Collaborator
|
Damn, I can't re-approve this. |
Collaborator
|
Now you can! |
cooperlees
approved these changes
Jul 12, 2021
Collaborator
cooperlees
left a comment
There was a problem hiding this comment.
One small step for Black, one giant leap for Python kind.
Collaborator
Author
|
I totally forgot about this PR after updating it, merging! edit: you can also mark a PR review as stale fyi |
mgmarino
added a commit
to mgmarino/black_nbconvert
that referenced
this pull request
Jul 20, 2021
black recently dropped this requirement (psf/black#2301), so this results in an error if this is run with a newer version of black.
This was referenced Jul 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tomlunfortunately has a lack of maintainership issue right now. It'sevident by the fact
tomlonly supports TOML v0.5.0. TOML v1.0.0 hasbeen recently released and right now Black crashes hard on its usage.
tomliis a brand new parse only TOML library. It supports TOMLv1.0.0. Although TBH we're switching to this one mostly because
pip is doing the same.
Blocked on pypa/pip#10035, fixes #2280.