Don't break long lines when type: ignore is present#1040
Merged
JelleZijlstra merged 1 commit intopsf:masterfrom Oct 3, 2019
Merged
Don't break long lines when type: ignore is present#1040JelleZijlstra merged 1 commit intopsf:masterfrom
type: ignore is present#1040JelleZijlstra merged 1 commit intopsf:masterfrom
Conversation
JelleZijlstra
approved these changes
Oct 2, 2019
msullivan
added a commit
to msullivan/black
that referenced
this pull request
Oct 11, 2019
In psf#1040 I had convinced myself that the type ignore logic didn't need anything like the ignored_ids from the type comment logic, but I was wrong, and we do. We hit these cases in practice a bunch.
JelleZijlstra
pushed a commit
that referenced
this pull request
Oct 11, 2019
In #1040 I had convinced myself that the type ignore logic didn't need anything like the ignored_ids from the type comment logic, but I was wrong, and we do. We hit these cases in practice a bunch.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As Guido discussed in #997, breaking long lines with
type: ignores has causedus a lot of grief when the
type: ignoreis moved off the line with the type error.Fixes #997.