Skip to content

phpunit 9 was released#52

Merged
muglug merged 7 commits intopsalm:masterfrom
SignpostMarv:patch-3
Feb 7, 2020
Merged

phpunit 9 was released#52
muglug merged 7 commits intopsalm:masterfrom
SignpostMarv:patch-3

Conversation

@SignpostMarv
Copy link
Copy Markdown
Contributor

bapcltd-marv added a commit to bapcltd/php-imap that referenced this pull request Feb 7, 2020
bapcltd-marv added a commit to bapcltd/php-imap that referenced this pull request Feb 7, 2020
@localheinz
Copy link
Copy Markdown

@SignpostMarv

Looks like the build failure is related to network issues - can you amend and push again to retrigger the builds?

@SignpostMarv
Copy link
Copy Markdown
Contributor Author

@localheinz currently waiting for all the builds to fail/some to pass, don't want to exacerbate the network issues.

had the network issues this week at the dayjob, 'tis frustrating.

bapcltd-marv added a commit to bapcltd/php-imap that referenced this pull request Feb 7, 2020
psalm travis config features a non-nightly 7.4 entry as of 3.8.1
@SignpostMarv
Copy link
Copy Markdown
Contributor Author

can you amend and push again to retrigger the builds?

sat at the day job, wasn't sure how to trigger a force push from the web interface, so added 7bf7bec

@SignpostMarv
Copy link
Copy Markdown
Contributor Author

@localheinz looks like it's failing on deps=high? https://travis-ci.org/psalm/phpunit-psalm-plugin/jobs/647274152#L372

ERROR: ArgumentTypeCoercion - hooks/TestCaseHandler.php:376:67 - Argument 1 of Psalm\Type\Union::__construct expects non-empty-array<int, Psalm\Type\Atomic>, parent type list<Psalm\Type\Atomic> provided

@weirdan
Copy link
Copy Markdown
Member

weirdan commented Feb 7, 2020

That's a valid complaint, unions should not be empty.

isolate build failures of `composer update` from `vimeo/psalm:dev-master`
@SignpostMarv
Copy link
Copy Markdown
Contributor Author

@weirdan just added bac311a to allow travis to isolate build failures caused solely by using vimeo/psalm:dev-master

@SignpostMarv
Copy link
Copy Markdown
Contributor Author

@weirdan @localheinz the bac311a theory seems to be working as expected, would it be appropriate to add allow_failures for DEPS="dev" ?

@weirdan
Copy link
Copy Markdown
Member

weirdan commented Feb 7, 2020

Dev failures isolation is fine, but note that even on 7.4-high the tests run with PHPUnit 7. There must be some other dependency preventing installation of newer PHPUnit versions (could be codeception or psalm-codeception module).

* codeception/phpunit-wrapper 7.x does not allow phpunit 8 to be installed
* codeception/base 2.5 does not allow codeception/phpunit-wrapper 8.x to be installed
@SignpostMarv
Copy link
Copy Markdown
Contributor Author

SignpostMarv commented Feb 7, 2020

@weirdan 4330aea should (hopefully) alleviate that somewhat, but as codeception/base has been archived, it looks like the psalm-codeception module will need to be updated when a corresponding update has been made to codeception in general.

edited: that made things worse, but it was codeception/base:^2.5 preventing the use of phpunit > 7.5

supporting newer versions of phpunit leads to an issue where if `Foo extends TestCase` and `TestCase::setUp()` does not explicitly return void, failure occurs.

see psalm#53
@SignpostMarv
Copy link
Copy Markdown
Contributor Author

a54c65c fails due to connection issues between travis and google ¬_¬: https://travis-ci.org/psalm/phpunit-psalm-plugin/jobs/647324167?utm_medium=notification&utm_source=github_status

while psalm#46 borrowed psalm's use of `composer clear cache` in psalm/psalm-plugin-phpunit@8250289, it didn't also include the vendor directory caching.
@SignpostMarv
Copy link
Copy Markdown
Contributor Author

23c57a0 borrows the cache directive from vimeo/psalm to trigger a fresh build as I'm not presently able to force-push.

@SignpostMarv
Copy link
Copy Markdown
Contributor Author

SignpostMarv commented Feb 7, 2020

oh ffs

edited: ditto

bapcltd-marv added a commit to bapcltd/php-imap that referenced this pull request Feb 7, 2020
@muglug muglug merged commit 59dbe2f into psalm:master Feb 7, 2020
@muglug
Copy link
Copy Markdown
Member

muglug commented Feb 7, 2020

Thanks, going to troubleshoot any issues upstream

@weirdan
Copy link
Copy Markdown
Member

weirdan commented Feb 7, 2020

You want to bump codeception-psalm-module to 0.3 and codeception to 4.0. It'll allow PHPUnit 8 (but not 9, yet). PHPUnit 9 is not allowed by codeception constraints yet, even though there's a corresponding bridge version already available.

bapcltd-marv added a commit to bapcltd/php-imap that referenced this pull request Feb 11, 2020
bapcltd-marv added a commit to bapcltd/php-imap that referenced this pull request Feb 11, 2020
bapcltd-marv added a commit to bapcltd/php-imap that referenced this pull request Feb 11, 2020
markovlatkovic added a commit to markovlatkovic/php-imap that referenced this pull request May 24, 2024
Patrici97 added a commit to Patrici97/php-imap that referenced this pull request Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants