Skip to content

Fix issue #1660, pry output error in base_helpers#1661

Merged
0x1eef merged 1 commit intopry:masterfrom
robsliwi:fix/pry_io_error
Oct 13, 2017
Merged

Fix issue #1660, pry output error in base_helpers#1661
0x1eef merged 1 commit intopry:masterfrom
robsliwi:fix/pry_io_error

Conversation

@robsliwi
Copy link
Copy Markdown
Contributor

Like described in
#1660 a simple
change fixes pry

Like described in
pry#1660 a simple
change fixes pry
@0x1eef 0x1eef self-assigned this Oct 13, 2017
@0x1eef 0x1eef self-requested a review October 13, 2017 21:04
Copy link
Copy Markdown
Contributor

@0x1eef 0x1eef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@0x1eef 0x1eef merged commit 775beea into pry:master Oct 13, 2017
@0x1eef
Copy link
Copy Markdown
Contributor

0x1eef commented Oct 13, 2017

Thanks a lot!
I tried checking out your code locally but it seemed quite hard to do via GitHub.

$ git fetch github/robsilwi # Your branch did not appear.
$ git pull github/robsliwi fix/pry_io_error
fatal: Couldn't find remote ref fix/pry_io_error

No worries. Thanks for the contribution.

@banister
Copy link
Copy Markdown
Member

@R-obert remember it's 0-9-11-stable that is our release branch atm.....maybe we should just reset master to this to avoid confusion?

banister pushed a commit that referenced this pull request Oct 18, 2017
Like described in
#1660 a simple
change fixes pry
@0x1eef 0x1eef mentioned this pull request Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants