Bug with module#prepend in ruby 2.0.0#1398
Merged
kyrylo merged 1 commit intopry:masterfrom Jun 29, 2015
Merged
Conversation
kyrylo
added a commit
that referenced
this pull request
Jun 29, 2015
Bug with module#prepend in ruby 2.0.0
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I found a bug when using
binding.pryinside a method that is wrapped with a prepended method.I'm not sure if the obtained behaviour is correct (the whereami title ends up being the module instead of the class instance), but at least fixes the infinite loop bug and provides a the minimum case to reproduce the loop.
Please let me know, if there's another way to fix it, and I can give it a try at doing it.
Thanks!