Refactor command hooks so they could use Pry::Hooks (newer API)#1391
Merged
Refactor command hooks so they could use Pry::Hooks (newer API)#1391
Conversation
Fixes #651 ({after,before}_command hooks should be unified with Pry::Hooks system) * The support for the `Pry.commands.{after,before}_command` API was kept * Hooks defined via the older API use random names * The order of hooks execution was changed from LIFO to FIFO
kyrylo
added a commit
that referenced
this pull request
Mar 11, 2015
Refactor command hooks so they could use Pry::Hooks (newer API)
0x1eef
reviewed
Sep 10, 2017
| # @see {Pry::CommandSet#after_command} | ||
| def hooks | ||
| @hooks ||= {:before => [], :after => []} | ||
| Pry.hooks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #651 ({after,before}_command hooks should be unified with
Pry::Hooks system)
Pry.commands.{after,before}_commandAPI was kept