deps: Update Guava to 32.0.0#12953
Closed
chadlwilson wants to merge 1 commit intoprotocolbuffers:mainfrom
chadlwilson:update-guava-32
Closed
deps: Update Guava to 32.0.0#12953chadlwilson wants to merge 1 commit intoprotocolbuffers:mainfrom chadlwilson:update-guava-32
chadlwilson wants to merge 1 commit intoprotocolbuffers:mainfrom
chadlwilson:update-guava-32
Conversation
fowles
approved these changes
Jun 7, 2023
googleberg
approved these changes
Jun 7, 2023
Contributor
Author
|
Thanks! Not sure if there is an automated backport review process, but created #13002 if useful (cherrypicked from the copybara |
copybara-service bot
pushed a commit
that referenced
this pull request
Jun 20, 2023
Follow-up from #12953 to update to `32.0.1` to fix an issue on windows: https://github.com/google/guava/releases/tag/v32.0.1 The underlying issue likely does not affect protobuf as it does not appear to (directly) use the affected `Files.createTempDir` or `FileBackedOutputStream` code which was apparently broken on Windows in `32.0.0`. Seems best to update anyway. Closes #13099 COPYBARA_INTEGRATE_REVIEW=#13099 from chadlwilson:bump-guava-3201 30bd3f7 PiperOrigin-RevId: 541960623
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates Guava to 32.0.0 to include fixes for CVE-2020-8908 and CVE-2023-2976 (google/guava#2575) which affects certain builds with shaded usage, e.g ruby via jruby/java platform such as https://rubygems.org/gems/google-protobuf/versions/3.23.2-java
Files.createTempDirorFileBackedOutputStreamcode which might behave differently on Windows.j2objc-annotationsfrom1.3-->2.8)May need backporting to
23.xbranch if sufficiently compatible.