fix(ui): apply ASCII logo gradient by X column, not string index#72
Conversation
ink-gradient maps colors by character index across the whole string, so the p descender (last two lines) always got the tail/pink color regardless of its leftward visual position. Fix: render each logo line separately with its own <Gradient>, padded to logoWidth so column X maps to the same gradient fraction on every line. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 4 minutes and 58 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
PRs targeting dev were not triggering CI checks, causing unverified merges. Adds dev to both push and pull_request branch filters so all agent-created feature PRs (which target dev by default) run CI. Fixes: PR #72 (fix/ascii-gradient-x-axis) had no CI checks.
Problem
The p's descender (bottom two lines of the ASCII logo) was rendering pink/purple instead of blue.
ink-gradientmaps gradient colors by character index across the entire multi-line string — so the last lines always got the tail color regardless of their leftward visual position.Fix
Render each logo line in its own
<Gradient>, padded tologoWidthwith trailing spaces. This ensures column X maps to the same gradient fraction on every line — character at x=3 is always ~10% through the gradient (blue) whether it's on line 1 or line 9.🤖 Generated with Claude Code