fix(cli): rename feedback dialog prompt from Qwen to proto#130
Merged
Conversation
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
WalkthroughThis change updates references from "Qwen" to "proto" in i18n message keys across multiple language locale files and the feedback dialog component. The translation values and surrounding logic remain unchanged; only the lookup keys and display text are updated. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 5
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/cli/src/i18n/locales/de.js`:
- Around line 308-309: The German translation for the key 'How is proto doing
this session? (optional)' still says "Qwen"; update the value to reference the
renamed prompt (e.g. replace "Qwen" with "Proto" and match capitalization), so
the translation becomes something like 'Wie macht sich Proto in dieser Sitzung?
(optional)'. Ensure you edit the string value corresponding to that exact key.
In `@packages/cli/src/i18n/locales/pt.js`:
- Around line 333-334: The Portuguese translation for the i18n key 'How is proto
doing this session? (optional)' still references "Qwen" — update the translation
value 'Como o Qwen está se saindo nesta sessão? (opcional)' to use "proto" to
match the key (e.g., 'Como o proto está se saindo nesta sessão? (opcional)').
Apply the same replacement for the corresponding entries in de.js, ru.js, and
zh.js so all locales use "proto" consistently with the i18n key.
In `@packages/cli/src/i18n/locales/ru.js`:
- Around line 331-332: The Russian translation for the feedback prompt keyed by
'How is proto doing this session? (optional)' still uses the old brand "Qwen";
update the value string in packages/cli/src/i18n/locales/ru.js to replace "Qwen"
with "proto" so the value reads 'Как дела у proto в этой сессии?
(необязательно)' (locate the mapping by the exact English key to make the
change).
In `@packages/cli/src/i18n/locales/zh.js`:
- Line 377: The Chinese translation for the key 'How is proto doing this
session? (optional)' still contains the old brand "Qwen"; update its value to
use "proto" instead by replacing 'Qwen 这次表现如何？（可选）' with 'proto 这次表现如何？（可选）' in
the locales object so the displayed prompt matches the key and current branding.
In `@packages/cli/src/ui/FeedbackDialog.tsx`:
- Line 51: The English locale entry for the feedback question is cased "Proto"
but the component FeedbackDialog.tsx and all other locales use lowercase
"proto", causing the i18n lookup to fail; update the English locale string for
the feedback key (the entry currently reading "How is Proto doing this session?
(optional)") to use lowercase "proto" so it exactly matches the key used by
FeedbackDialog.tsx and the other locale files.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: c7e326c6-fca3-488c-b5b2-60f890cd12a9
📒 Files selected for processing (5)
packages/cli/src/i18n/locales/de.jspackages/cli/src/i18n/locales/pt.jspackages/cli/src/i18n/locales/ru.jspackages/cli/src/i18n/locales/zh.jspackages/cli/src/ui/FeedbackDialog.tsx
Comment on lines
+308
to
309
| 'How is proto doing this session? (optional)': | ||
| 'Wie macht sich Qwen in dieser Sitzung? (optional)', |
There was a problem hiding this comment.
Align the German translation value with the renamed “proto” prompt.
Line 309 still references “Qwen”, so the visible German feedback question does not reflect the branding change.
Suggested fix
'How is proto doing this session? (optional)':
- 'Wie macht sich Qwen in dieser Sitzung? (optional)',
+ 'Wie macht sich proto in dieser Sitzung? (optional)',📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| 'How is proto doing this session? (optional)': | |
| 'Wie macht sich Qwen in dieser Sitzung? (optional)', | |
| 'How is proto doing this session? (optional)': | |
| 'Wie macht sich proto in dieser Sitzung? (optional)', |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/cli/src/i18n/locales/de.js` around lines 308 - 309, The German
translation for the key 'How is proto doing this session? (optional)' still says
"Qwen"; update the value to reference the renamed prompt (e.g. replace "Qwen"
with "Proto" and match capitalization), so the translation becomes something
like 'Wie macht sich Proto in dieser Sitzung? (optional)'. Ensure you edit the
string value corresponding to that exact key.
Comment on lines
+333
to
334
| 'How is proto doing this session? (optional)': | ||
| 'Como o Qwen está se saindo nesta sessão? (opcional)', |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check all locale files for the feedback dialog key and verify translation values
echo "=== Checking i18n key and translation values in all locale files ==="
rg -A1 "How is proto doing this session" packages/cli/src/i18n/locales/
echo ""
echo "=== Searching for any remaining 'Qwen' references in translation values ==="
rg -n "está se saindo|macht sich|дела у|表现如何" packages/cli/src/i18n/locales/ -C2Repository: protoLabsAI/protoCLI
Length of output: 210
🏁 Script executed:
#!/bin/bash
# Check if the file exists and examine its structure
echo "=== Checking if pt.js exists ==="
ls -la packages/cli/src/i18n/locales/pt.js 2>&1
echo ""
echo "=== Total lines in pt.js ==="
wc -l packages/cli/src/i18n/locales/pt.js 2>&1
echo ""
echo "=== Content around lines 333-334 ==="
sed -n '330,340p' packages/cli/src/i18n/locales/pt.js 2>&1
echo ""
echo "=== Searching for 'proto' in pt.js ==="
rg -n "proto" packages/cli/src/i18n/locales/pt.js 2>&1
echo ""
echo "=== Searching for 'Qwen' in pt.js ==="
rg -n "Qwen" packages/cli/src/i18n/locales/pt.js 2>&1
echo ""
echo "=== Listing all locale files ==="
ls -la packages/cli/src/i18n/locales/ 2>&1Repository: protoLabsAI/protoCLI
Length of output: 7408
🏁 Script executed:
#!/bin/bash
# Check the "How is proto doing this session" key in all locale files
echo "=== Checking the key in all locale files ==="
for file in packages/cli/src/i18n/locales/*.js; do
echo ""
echo "--- $file ---"
grep -A1 "How is proto doing this session" "$file" || echo "[key not found]"
done
echo ""
echo "=== Checking English (en.js) for reference ==="
sed -n '330,340p' packages/cli/src/i18n/locales/en.jsRepository: protoLabsAI/protoCLI
Length of output: 1244
Incomplete branding update: Portuguese translation still references "Qwen".
The i18n key was updated to reference "proto", but the Portuguese translation value still says "Qwen": "Como o Qwen está se saindo nesta sessão? (opcional)". This inconsistency is present in multiple locale files (de.js, pt.js, ru.js, and zh.js), where the key uses "proto" but all translation values still reference "Qwen".
✏️ Suggested fix
'How is proto doing this session? (optional)':
- 'Como o Qwen está se saindo nesta sessão? (opcional)',
+ 'Como o proto está se saindo nesta sessão? (opcional)',📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| 'How is proto doing this session? (optional)': | |
| 'Como o Qwen está se saindo nesta sessão? (opcional)', | |
| 'How is proto doing this session? (optional)': | |
| 'Como o proto está se saindo nesta sessão? (opcional)', |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/cli/src/i18n/locales/pt.js` around lines 333 - 334, The Portuguese
translation for the i18n key 'How is proto doing this session? (optional)' still
references "Qwen" — update the translation value 'Como o Qwen está se saindo
nesta sessão? (opcional)' to use "proto" to match the key (e.g., 'Como o proto
está se saindo nesta sessão? (opcional)'). Apply the same replacement for the
corresponding entries in de.js, ru.js, and zh.js so all locales use "proto"
consistently with the i18n key.
Comment on lines
+331
to
332
| 'How is proto doing this session? (optional)': | ||
| 'Как дела у Qwen в этой сессии? (необязательно)', |
There was a problem hiding this comment.
Update the Russian prompt value to use “proto” instead of “Qwen”.
Line 332 still shows the old brand, so the feedback dialog text remains inconsistent for Russian users.
Suggested fix
'How is proto doing this session? (optional)':
- 'Как дела у Qwen в этой сессии? (необязательно)',
+ 'Как дела у proto в этой сессии? (необязательно)',📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| 'How is proto doing this session? (optional)': | |
| 'Как дела у Qwen в этой сессии? (необязательно)', | |
| 'How is proto doing this session? (optional)': | |
| 'Как дела у proto в этой сессии? (необязательно)', |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/cli/src/i18n/locales/ru.js` around lines 331 - 332, The Russian
translation for the feedback prompt keyed by 'How is proto doing this session?
(optional)' still uses the old brand "Qwen"; update the value string in
packages/cli/src/i18n/locales/ru.js to replace "Qwen" with "proto" so the value
reads 'Как дела у proto в этой сессии? (необязательно)' (locate the mapping by
the exact English key to make the change).
| 'Show Welcome Back Dialog': '显示欢迎回来对话框', | ||
| 'Enable User Feedback': '启用用户反馈', | ||
| 'How is Qwen doing this session? (optional)': 'Qwen 这次表现如何？（可选）', | ||
| 'How is proto doing this session? (optional)': 'Qwen 这次表现如何？（可选）', |
There was a problem hiding this comment.
Replace “Qwen” with “proto” in the Chinese feedback prompt value.
Line 377 updates the key but keeps “Qwen” in the rendered Chinese text, so users still see the old branding.
Suggested fix
- 'How is proto doing this session? (optional)': 'Qwen 这次表现如何？（可选）',
+ 'How is proto doing this session? (optional)': 'proto 这次表现如何？（可选）',📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| 'How is proto doing this session? (optional)': 'Qwen 这次表现如何？（可选）', | |
| 'How is proto doing this session? (optional)': 'proto 这次表现如何？（可选）', |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/cli/src/i18n/locales/zh.js` at line 377, The Chinese translation for
the key 'How is proto doing this session? (optional)' still contains the old
brand "Qwen"; update its value to use "proto" instead by replacing 'Qwen
这次表现如何？（可选）' with 'proto 这次表现如何？（可选）' in the locales object so the displayed
prompt matches the key and current branding.
| <Box> | ||
| <Text color="cyan">● </Text> | ||
| <Text bold>{t('How is Qwen doing this session? (optional)')}</Text> | ||
| <Text bold>{t('How is proto doing this session? (optional)')}</Text> |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify the exact i18n key used in all locale files
echo "=== Checking exact key in all locale files ==="
echo ""
echo "English locale:"
rg -n "How is (proto|Proto) doing this session" packages/cli/src/i18n/locales/en.js
echo ""
echo "Portuguese locale:"
rg -n "How is (proto|Proto) doing this session" packages/cli/src/i18n/locales/pt.js
echo ""
echo "Chinese locale:"
rg -n "How is (proto|Proto) doing this session" packages/cli/src/i18n/locales/zh.js
echo ""
echo "German locale:"
rg -n "How is (proto|Proto) doing this session" packages/cli/src/i18n/locales/de.js
echo ""
echo "Russian locale:"
rg -n "How is (proto|Proto) doing this session" packages/cli/src/i18n/locales/ru.js
echo ""
echo "=== Key used in FeedbackDialog.tsx ==="
rg -n "How is (proto|Proto) doing this session" packages/cli/src/ui/FeedbackDialog.tsxRepository: protoLabsAI/protoCLI
Length of output: 658
Fix i18n key casing mismatch in English locale file.
The English locale file uses uppercase "Proto" ('How is Proto doing this session? (optional)' at en.js:393-394), while all other locale files (Portuguese, Chinese, German, Russian) and FeedbackDialog.tsx use lowercase "proto" ('How is proto doing this session? (optional)'). This mismatch will cause the English translation lookup to fail, displaying the raw i18n key instead of the translated text to English users.
Update packages/cli/src/i18n/locales/en.js line 393 to use lowercase "proto" to match all other locales and the component code.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/cli/src/ui/FeedbackDialog.tsx` at line 51, The English locale entry
for the feedback question is cased "Proto" but the component FeedbackDialog.tsx
and all other locales use lowercase "proto", causing the i18n lookup to fail;
update the English locale string for the feedback key (the entry currently
reading "How is Proto doing this session? (optional)") to use lowercase "proto"
so it exactly matches the key used by FeedbackDialog.tsx and the other locale
files.
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
mabry1985
added a commit
that referenced
this pull request
Apr 26, 2026
* fix(cli): rename feedback dialog prompt from Qwen to proto (#130) Co-authored-by: Automaker <automaker@localhost> Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com> * chore: release v0.26.14 (#131) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix(plan): exit_plan_mode silently rejected under YOLO YOLO bypassed getConfirmationDetails for exit_plan_mode, so the tool's onConfirm never ran and wasApproved stayed false — execute() then reported "Plan execution was not approved" even when the user wanted the plan to proceed. Treat exit_plan_mode like ask_user_question and keep the confirmation dialog wired up in YOLO mode. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Automaker <automaker@localhost> Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
mabry1985
added a commit
that referenced
this pull request
Apr 26, 2026
…7229277 chore: sync main into dev (resolve v0.26.14 + #130 feedback fix)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The feedback dialog was still showing 'How is Qwen doing this session?' — updated the i18n key in
FeedbackDialog.tsxand all 4 locale files (zh, de, ru, pt) to use 'proto' instead.Summary by CodeRabbit