Skip to content

Feat: add test cases for Alertmanager secret config Jira receiver#8349

Merged
simonpasquier merged 2 commits intoprometheus-operator:mainfrom
nutmos:feat/add-amcfg-test-jira-sanitize-config
Feb 4, 2026
Merged

Feat: add test cases for Alertmanager secret config Jira receiver#8349
simonpasquier merged 2 commits intoprometheus-operator:mainfrom
nutmos:feat/add-amcfg-test-jira-sanitize-config

Conversation

@nutmos
Copy link
Contributor

@nutmos nutmos commented Feb 1, 2026

Description

This PR adds test cases for sanitize methods of Jira receiver, separated from CR implement in another PR.

Relate: #7971

Type of change

What type of changes does your code introduce to the Prometheus operator? Put an x in the box that apply.

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Verification

Unit Testing

Changelog entry

- Add test cases for Jira receiver sanitize method in Alertmanager secret config

for the missing comparison
@nutmos nutmos marked this pull request as ready for review February 2, 2026 23:25
@nutmos nutmos requested a review from a team as a code owner February 2, 2026 23:25
@nutmos
Copy link
Contributor Author

nutmos commented Feb 2, 2026

@simonpasquier this is to separate the unit test implement. Pls review.

Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@simonpasquier simonpasquier merged commit 825cca8 into prometheus-operator:main Feb 4, 2026
22 checks passed
nutmos added a commit to nutmos/prometheus-operator that referenced this pull request Feb 14, 2026
…ometheus-operator#8349)

* amcfg: add jira sanitize test cases for alertmanager secret config

* amcfg: add golden file

for the missing comparison
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants