fix: labelmap replacement validation for template variables by heliapb · Pull Request #8337 · prometheus-operator/prometheus-operator

heliapb · 2026-01-27T20:41:58Z

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.

Closes: #8336

If you're contributing for the first-time, check our contribution guidelines.

Type of change

What type of changes does your code introduce to the Prometheus operator? Put an x in the box that apply.

CHANGE (fix or feature that would cause existing functionality to not work as expected)
FEATURE (non-breaking change which adds functionality)
BUGFIX (non-breaking change which fixes an issue)
ENHANCEMENT (non-breaking change which improves existing functionality)
NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Verification

Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.

Changelog entry

Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.

simonpasquier · 2026-01-28T10:47:49Z

pkg/prometheus/validation/validator.go

 	}

-	if action == string(relabel.LabelMap) && (rc.Replacement != nil) && !lcv.isValidLabelName(*rc.Replacement) {
+	if action == string(relabel.LabelMap) && (rc.Replacement != nil) && !varInRegexTemplate(*rc.Replacement) && !lcv.isValidLabelName(*rc.Replacement) {


Prometheus uses a different regexp to validate (https://github.com/prometheus/prometheus/pull/17372/changes). Should we copy it?

ok should I then do the same as in https://github.com/prometheus-operator/prometheus-operator/blob/main/pkg/prometheus/validation/validator.go#L63 varInRegexTemplate cp the code right? and follow the same logic for the validation, will work on it, thanks

Signed-off-by: Hélia Barroso <helia_barroso@hotmail.com>

slashpai

@simonpasquier do you want to take another look?

…r to v0.90.0 (#4885) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [prometheus-operator/prometheus-operator](https://github.com/prometheus-operator/prometheus-operator) | minor | `v0.89.0` → `v0.90.0` | --- > ⚠️ **Warning** > > Some dependencies could not be looked up. Check the [Dependency Dashboard](issues/2) for more information. --- ### Release Notes <details> <summary>prometheus-operator/prometheus-operator (prometheus-operator/prometheus-operator)</summary> ### [`v0.90.0`](https://github.com/prometheus-operator/prometheus-operator/releases/tag/v0.90.0): 0.90.0 / 2026-03-19 [Compare Source](prometheus-operator/prometheus-operator@v0.89.0...v0.90.0) - \[CHANGE/BUGFIX] Validate that the remote-write URL scheme is either `http` or `https`. [#8455](prometheus-operator/prometheus-operator#8455) - \[FEATURE] Add `--repair-policy-for-statefulsets` CLI argument to the operator. It defines how the operator manages StatefulSet's pods stuck at an incorrect revision. Users running Kubernetes v1.35+ are encouraged to enable this feature (see [troubleshooting guide](https://prometheus-operator.dev/docs/platform/troubleshooting/#statefulset-rollout-stuck-after-a-bad-update)). [#8443](prometheus-operator/prometheus-operator#8443) - \[FEATURE] Add `schedulerName` support to the `Prometheus`, `PrometheusAgent`, `Alertmanager` and `ThanosRuler` CRDs. [#8451](prometheus-operator/prometheus-operator#8451) - \[ENHANCEMENT] Add `--web.tls-curves` CLI argument to the operator and admission-webhook binaries. [#8385](prometheus-operator/prometheus-operator#8385) - \[ENHANCEMENT] Support minimum TLS version for Thanos gRPC servers. [#8438](prometheus-operator/prometheus-operator#8438) - \[ENHANCEMENT] Add version label to `ThanosRuler` pods. [#8441](prometheus-operator/prometheus-operator#8441) - \[ENHANCEMENT] Add `messageText` support for Slack receiver in `AlertmanagerConfig` CRD. [#8374](prometheus-operator/prometheus-operator#8374) - \[ENHANCEMENT] Add `messageText` support for Slack receiver in Alertmanager secret config. [#8375](prometheus-operator/prometheus-operator#8375) - \[ENHANCEMENT] Add `forceImplicitTLS` support for SMTP email config in Alertmanager secret config. [#8384](prometheus-operator/prometheus-operator#8384) [#8404](prometheus-operator/prometheus-operator#8404) - \[ENHANCEMENT] Add `forceImplicitTLS` support for SMTP email config in `AlertmanagerConfig` CRD. [#8386](prometheus-operator/prometheus-operator#8386) - \[ENHANCEMENT] Add `forceImplicitTLS` support for SMTP global config in Alertmanager secret config. [#8405](prometheus-operator/prometheus-operator#8405) - \[ENHANCEMENT] Add `forceImplicitTLS` support for SMTP global config in `Alertmanager` CRD. [#8406](prometheus-operator/prometheus-operator#8406) - \[ENHANCEMENT] Add support for global Telegram bot token in `Alertmanager` CRD. [#8372](prometheus-operator/prometheus-operator#8372) - \[ENHANCEMENT] Add `chatIDFile` support for Telegram receiver in Alertmanager secret config. [#8376](prometheus-operator/prometheus-operator#8376) - \[ENHANCEMENT] Add `wechatAPISecretFile` support in Alertmanager global config. [#8377](prometheus-operator/prometheus-operator#8377) - \[ENHANCEMENT] Add `authSecretFile` support for email config in Alertmanager secret config. [#8396](prometheus-operator/prometheus-operator#8396) - \[ENHANCEMENT] Add nested field support for PagerDuty description in Alertmanager secret config. [#8402](prometheus-operator/prometheus-operator#8402) - \[ENHANCEMENT] Add email threading support in Alertmanager secret config. [#8388](prometheus-operator/prometheus-operator#8388) - \[ENHANCEMENT] Add field and label selectors for ConfigMap watches. [#8368](prometheus-operator/prometheus-operator#8368) - \[ENHANCEMENT] Improve ScrapeConfig API consistency and validation. [#8422](prometheus-operator/prometheus-operator#8422) - \[BUGFIX] Fix `ThanosRuler` config resource status not being updated on initial StatefulSet creation. [#8358](prometheus-operator/prometheus-operator#8358) - \[BUGFIX] Preserve `LastTransitionTime` in Prometheus status conditions. [#8346](prometheus-operator/prometheus-operator#8346) - \[BUGFIX] Make Mattermost `text` field optional in `AlertmanagerConfig` CRD. [#8363](prometheus-operator/prometheus-operator#8363) - \[BUGFIX] Remove nil error wrapping in v1alpha1 duplicate receiver validation. [#8379](prometheus-operator/prometheus-operator#8379) - \[BUGFIX] Aggregate `Available` condition across Prometheus shards. [#8434](prometheus-operator/prometheus-operator#8434) - \[BUGFIX] Reconcile resources with inconsistent status. [#8397](prometheus-operator/prometheus-operator#8397) - \[BUGFIX] Fix namespace lister/watcher compatibility with Kubernetes v1.35 client-go. [#8431](prometheus-operator/prometheus-operator#8431) - \[BUGFIX] Fix missing OAuth2 field in IonosSDConfig generation. [#8433](prometheus-operator/prometheus-operator#8433) - \[BUGFIX] Fix missing fields in AzureSDConfig. [#8444](prometheus-operator/prometheus-operator#8444) - \[BUGFIX] Validate Microsoft Teams V2 URL in `AlertmanagerConfig` CRD. [#8227](prometheus-operator/prometheus-operator#8227) - \[BUGFIX] Fix `labelmap` relabel action rejecting valid replacement values with template variables for Prometheus 2.x. [#8337](prometheus-operator/prometheus-operator#8337) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/4885 Co-authored-by: Renovate Bot <renovate-bot@alexlebens.net> Co-committed-by: Renovate Bot <renovate-bot@alexlebens.net>

heliapb requested a review from a team as a code owner January 27, 2026 20:41

pull-request-size bot added the size/S label Jan 27, 2026

heliapb force-pushed the fix/relabel_bug branch from a56a71e to ec8bdeb Compare January 28, 2026 09:48

simonpasquier reviewed Jan 28, 2026

View reviewed changes

pull-request-size bot added size/M and removed size/S labels Jan 28, 2026

heliapb force-pushed the fix/relabel_bug branch 3 times, most recently from 189b477 to 19f0e39 Compare January 29, 2026 10:41

heliapb force-pushed the fix/relabel_bug branch 2 times, most recently from fa3cb2c to 999f092 Compare February 23, 2026 21:35

heliapb requested a review from simonpasquier February 23, 2026 21:35

heliapb force-pushed the fix/relabel_bug branch from 999f092 to 6423b7c Compare February 26, 2026 09:41

heliapb force-pushed the fix/relabel_bug branch from 6423b7c to 79383a0 Compare March 11, 2026 10:18

fix: regex validation

810dd65

Signed-off-by: Hélia Barroso <helia_barroso@hotmail.com>

heliapb force-pushed the fix/relabel_bug branch from 79383a0 to 810dd65 Compare March 18, 2026 15:34

heliapb mentioned this pull request Mar 18, 2026

chore: cut v0.90.0 #8454

Merged

5 tasks

slashpai approved these changes Mar 18, 2026

View reviewed changes

heliapb changed the title ~~Fix labelmap replacement validation for template variables~~ fix: labelmap replacement validation for template variables Mar 18, 2026

simonpasquier merged commit a2cf4b2 into prometheus-operator:main Mar 19, 2026
22 checks passed

heliapb deleted the fix/relabel_bug branch March 19, 2026 09:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: labelmap replacement validation for template variables#8337

fix: labelmap replacement validation for template variables#8337
simonpasquier merged 1 commit intoprometheus-operator:mainfrom
heliapb:fix/relabel_bug

heliapb commented Jan 27, 2026

Uh oh!

simonpasquier Jan 28, 2026

Uh oh!

heliapb Jan 28, 2026

Uh oh!

slashpai left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

heliapb commented Jan 27, 2026

Description

Type of change

Verification

Changelog entry

Uh oh!

simonpasquier Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

heliapb Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

slashpai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants