[feat] - Refactor KumaSDConfigs#7241
[feat] - Refactor KumaSDConfigs#7241Dharma-09 wants to merge 3 commits intoprometheus-operator:mainfrom
Conversation
|
Hi @Dharma-09 , you need to run |
mviswanathsai
left a comment
There was a problem hiding this comment.
A few comments regarding the e2e tests and version checks.
|
(nit) could you also add a few tests for the CC: @slashpai |
slashpai
left a comment
There was a problem hiding this comment.
For e2e tests lets add both positive and negative case for each field.
| }, | ||
| }, | ||
| expectedError: false, | ||
| }, |
There was a problem hiding this comment.
Add a case for invalid url also?
c2e6b09 to
2c507c3
Compare
2c507c3 to
0855ad4
Compare
|
Hi @mviswanathsai I rebased my branch for PR #7241, but it pulled in some unintended changes. How can I fix this and keep only my intended updates? Also, is there a Slack channel where I can ask for help on issues like this? |
|
@Dharma-09 Rebase can be hard sometimes if branch is a bit behind upstream as more changes would have merged. What I follow to rebase usually is For a easier solution, I would suggest you to create a new branch from current upstream main and cherry-pick your commits from this branch on top of it. If you are unsure about any git commands its always better to create a backup of current branch, so incase if something is messed up its easy to fix :) |
Description
This pull request refactors the validation logic for the KumaSDConfig struct in the Prometheus Operator. The changes include improving the handling of configuration fields such as
server,ClientID,TLSConfig,ProxyURL,AllowRedirect.Fixes
#7203
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.
Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.