pkg/alertmanager: added hostAliases to pod spec (fixes #3488)#3944
Closed
suvl wants to merge 2 commits intoprometheus-operator:mainfrom
suvl:feat-alertmanager-hostaliases
Closed
pkg/alertmanager: added hostAliases to pod spec (fixes #3488)#3944suvl wants to merge 2 commits intoprometheus-operator:mainfrom suvl:feat-alertmanager-hostaliases
suvl wants to merge 2 commits intoprometheus-operator:mainfrom
suvl:feat-alertmanager-hostaliases
Conversation
Contributor
|
I think a more sustainable solution to this is some kind of deep-merge approach using PodSpec like the |
Author
|
@coderanger well that's a much bigger change than these few lines. I can work on it (hoping we have enough tests to cover such a change and make this swift) but in such case this PR should be closed. On the other hand, this PR is much more surgical in the changes it makes. Let me know what the team thinks to be the way forward. |
|
Hello, we need this feature so what's the status ? |
Author
|
#4787 beated me to it. closing. |
Contributor
|
@suvl thanks for the effort! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3488.