Allow user to configure pod hostAliases#4787
Merged
simonpasquier merged 1 commit intoprometheus-operator:mainfrom Jun 2, 2022
Merged
Allow user to configure pod hostAliases#4787simonpasquier merged 1 commit intoprometheus-operator:mainfrom
simonpasquier merged 1 commit intoprometheus-operator:mainfrom
Conversation
Contributor
simonpasquier
left a comment
There was a problem hiding this comment.
could you add unit tests for Prometheus and Alertmanager? thanks!
12c6ba8 to
c29146f
Compare
Contributor
Author
|
@simonpasquier I have added the test case for Prometheus and Alertmanager, but I need help on the e2e build error. Currently I am not familiar with the controller-gen, could you please help me on this? |
Contributor
|
I believe that to make it work, we have to declare our own |
Contributor
Author
|
@simonpasquier thanks! I think I got what you meant. Let me study about the controller-gen before continuing this :) |
df59cb0 to
6ee2111
Compare
Contributor
simonpasquier
left a comment
There was a problem hiding this comment.
I just a few minor comments otherwise this is looking great!
Thanos Pods. Signed-off-by: heylongdacoder <heylongdacoder@gmail.com>
6ee2111 to
18b0008
Compare
Contributor
Author
|
@simonpasquier thanks for the review, I learnt something :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3488, Fixes #4298
Signed-off-by: heylongdacoder heylongdacoder@gmail.com
Description
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.