chore!: adopt log/slog, drop go-kit/log#378
Merged
SuperQ merged 2 commits intoprometheus-community:masterfrom Nov 4, 2024
Merged
chore!: adopt log/slog, drop go-kit/log#378SuperQ merged 2 commits intoprometheus-community:masterfrom
SuperQ merged 2 commits intoprometheus-community:masterfrom
Conversation
Also bumps the minimum go version in go.mod to 1.22 to support log/slog, for exporter-toolkit support. Signed-off-by: TJ Hoplock <t.hoplock@gmail.com>
The bulk of this PR was automated by the following script which is being used to aid in converting the various exporters/projects to use slog: https://gist.github.com/tjhop/49f96fb7ebbe55b12deee0b0312d8434 Other changes include: - removing unneeded linter settings for go-kit/log - enabling sloglint linter Signed-off-by: TJ Hoplock <t.hoplock@gmail.com>
Contributor
Author
|
cc: @SuperQ |
SuperQ
approved these changes
Nov 4, 2024
SuperQ
added a commit
to kgeckhart/stackdriver_exporter
that referenced
this pull request
Nov 4, 2024
Add prometheus-community#378 Signed-off-by: Ben Kochie <superq@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bulk of this PR was automated by the following script which is being
used to aid in converting the various exporters/projects to use slog:
https://gist.github.com/tjhop/49f96fb7ebbe55b12deee0b0312d8434
Other changes include: