Add more info about filters to docs and rename struct fields#198
Merged
SuperQ merged 5 commits intoprometheus-community:masterfrom Jun 4, 2024
Merged
Conversation
744ff37 to
68f0b54
Compare
|
This looks good, is there someone who can review it? |
Contributor
Author
I think only @SuperQ can approve PR's ATM |
|
Hey @SuperQ - I'm bumping into this again, It would really save me a tonne of bother if we could get this approved. 🙏 |
507f6b3 to
d55e8dd
Compare
Signed-off-by: Kyle Eckhart <kgeckhart@users.noreply.github.com>
Signed-off-by: Kyle Eckhart <kgeckhart@users.noreply.github.com>
Signed-off-by: Kyle Eckhart <kgeckhart@users.noreply.github.com>
Signed-off-by: Kyle Eckhart <kgeckhart@users.noreply.github.com>
Signed-off-by: Kyle Eckhart <kgeckhart@users.noreply.github.com>
d55e8dd to
1ec3046
Compare
Contributor
Author
|
Should be good to go now @SuperQ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjusts the way
monitoring.filtersare documented and applied.Similar to #165, I found it hard to use the filters initially so hopefully more detailed docs can help. Especially related to the fact that the
monitoring.filtersflag should be specified multiple times vs comma delimited like other multi-valued params.This also adjusts the way the filters are applied to be based on prefix vs contains, 507f6b3. I think the original contains implementation made it hard to define what exactly belongs in the first section of the extra_filters. Forcing it to be a prefix makes it a lot more concrete.