Migrate From go-kit/kit/log to go-kit/log#8927
Merged
roidelapluie merged 4 commits intoprometheus:mainfrom Jun 11, 2021
Merged
Conversation
Signed-off-by: Levi Harrison <git@leviharrison.dev>
cb13d45 to
07fce43
Compare
Signed-off-by: Levi Harrison <git@leviharrison.dev>
Signed-off-by: Levi Harrison <git@leviharrison.dev>
Signed-off-by: Levi Harrison <git@leviharrison.dev>
07fce43 to
0027389
Compare
Contributor
Author
|
A side effect of this mass change is hitting all the code owners possible (except for React). Sorry! |
Member
|
Thanks! |
This was referenced Aug 13, 2021
2 tasks
cristiangreco
added a commit
to grafana/cortex-tools
that referenced
this pull request
Nov 3, 2021
For consistency with Cortex and Prometheus, see - cortexproject/cortex#4421 - prometheus/prometheus#8927
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go-kit/logis a slimmed-down version ofgo-kit/kit/logwhich only contains thelogpackage that we use. This PR moves everything togo-kit/logand adds adepguardrule to make sure we don't accidentally import the larger one in the future.