Merged
Conversation
Member
|
Can we check that release candidates do not get this tag ? @SuperQ @simonpasquier WDYT? |
SuperQ
reviewed
Oct 8, 2020
Member
|
@roidelapluie We control the |
SuperQ
reviewed
Oct 8, 2020
When the latest tag is added, also add a tag for the major version when the version tag matches the latest release defined in VERSION. Signed-off-by: Victor Araujo <vear91@gmail.com>
789072c to
67d5b36
Compare
Member
|
Thanks! |
|
Is this available yet? I tried ":2" and ":v2" both did not work. |
Member
|
I missed that we do not push the image, and that we also tag the RC releases with this(which we should not) |
roidelapluie
added a commit
to roidelapluie/prometheus
that referenced
this pull request
Jan 19, 2026
In commit 74775d7 "Add major version tag (prometheus#8026)" from 2020, the docker-tag-latest target was updated to create major version tags (v2, v3, etc.) but these tags were never actually pushed to the registry. They existed locally only after tagging but were never published. This commit fixes the issue by: - Adding logic to docker-publish to push major version tags when DOCKER_IMAGE_TAG="latest" (triggered by promci during releases) - Adding logic to docker-manifest to create major version manifests when DOCKER_IMAGE_TAG="latest" Pre-release filtering is handled at the promci level, where the regex check ^v[0-9]+(\.[0-9]+){2}$ already ensures only stable releases trigger the "latest" tagging workflow. Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the latest tag is added, also add a tag for the major version
when the version tag matches the latest release defined in VERSION.
Closes #7824