Conversation
Signed-off-by: Goutham Veeramachaneni <cs14btech11014@iith.ac.in>
|
I think in the previous PR it was discussed that this is a breaking change and thus must be deferred until 2.0. But you can just change the target branch from master to dev-2.0. |
|
My bad, fixed it. Thanks @brancz |
|
Just a stub as I'll forget about this, but it might be worth noting the |
|
Anything further speaking against merging this? |
|
To anyone who comes across this: The correct UID would be |
|
Yep for me it is also 65534. |
|
Nobody is a very bad choice. To mount the data directory as a volume I have to give write permissions on my host to nobody, which is 'nomen est omen' should not have write permissions to any directory. |
|
It doesn't mean you should run it as that user, but that you can run it as any user/group combination, giving you the possibility to choose permissions rather than the image forcing you into some seemingly random UID/GID combination. |
|
Isn't it a pretty standard practice to run a docker container processes as root? In this configuration, using attached volumes becomes tricky compared to most every other docker container I've worked with. Basically, I need a startup script to make sure Prometheus has write access to its data volume |
### Motivation As seen below, there is a fix for one of the Grafana dashboards that are currently broken in this project (available since version 0.0.5): - [The Pulsar-topics metrics can't load in Grafana](streamnative/charts#49) Additionally, upgrading Prometheus to the latest version improves performance as seen here: https://prometheus.io/blog/2017/11/08/announcing-prometheus-2-0 ### Modifications Bring Docker images to their most up-to-date version (streamnative/apache-pulsar-grafana-dashboard-k8s:0.0.6, prom/prometheus:v2.17.2) to fix the following issues: - streamnative/charts#49 <- fixes Pulsar-topics metrics failure to load - prometheus/prometheus#2859 <- prevent escalation vulnerabilities by defaulting to the ```nobody``` user **Note**: upgrading to the latest version of Prometheus (currently v2.17.2) caused the pod to fail with the following error: ```open /prometheus/queries.active: permission denied```. In order to fix this issue I followed the instructions from these 2 comments: - [Permission denied UID/GID solution](prometheus/prometheus#5976 (comment)) - [Unable to create mmap-ed active query log securityContext fix](aws/eks-charts#21 (comment)) ### Verifying this change - [x] Make sure that the change passes the CI checks.
This needs the mounted directory to be owned by
99:99@sdurrheimer @grobie @jimmidyson @devx @brian-brazil @brancz @fabxc
This change is