refactor: switch OTLP handler to AppendableV2#17996
Merged
Conversation
22 tasks
4bed39c to
be35384
Compare
bwplotka
commented
Feb 3, 2026
storage/remote/otlptranslator/prometheusremotewrite/metrics_to_prw_test.go
Show resolved
Hide resolved
bwplotka
commented
Feb 3, 2026
storage/remote/otlptranslator/prometheusremotewrite/combined_appender_test.go
Show resolved
Hide resolved
Signed-off-by: bwplotka <bwplotka@gmail.com>
be35384 to
afabbaa
Compare
aknuds1
requested changes
Feb 3, 2026
Contributor
aknuds1
left a comment
There was a problem hiding this comment.
Please see my otlpInstrumentedAppender.Append comment for a potential bug.
4 tasks
760e84b to
60812e0
Compare
Signed-off-by: bwplotka <bwplotka@gmail.com>
60812e0 to
358e54a
Compare
wbollock
pushed a commit
to wbollock/prometheus
that referenced
this pull request
Feb 6, 2026
* refactor: switch OTLP handler to AppendableV2 Signed-off-by: bwplotka <bwplotka@gmail.com> * addressed comments Signed-off-by: bwplotka <bwplotka@gmail.com> --------- Signed-off-by: bwplotka <bwplotka@gmail.com> Signed-off-by: Will Bollock <wbollock@linode.com>
wbollock
pushed a commit
to wbollock/prometheus
that referenced
this pull request
Feb 6, 2026
* refactor: switch OTLP handler to AppendableV2 Signed-off-by: bwplotka <bwplotka@gmail.com> * addressed comments Signed-off-by: bwplotka <bwplotka@gmail.com> --------- Signed-off-by: bwplotka <bwplotka@gmail.com>
wbollock
pushed a commit
to wbollock/prometheus
that referenced
this pull request
Feb 6, 2026
* refactor: switch OTLP handler to AppendableV2 Signed-off-by: bwplotka <bwplotka@gmail.com> * addressed comments Signed-off-by: bwplotka <bwplotka@gmail.com> --------- Signed-off-by: bwplotka <bwplotka@gmail.com>
wbollock
pushed a commit
to wbollock/prometheus
that referenced
this pull request
Feb 6, 2026
* refactor: switch OTLP handler to AppendableV2 Signed-off-by: bwplotka <bwplotka@gmail.com> * addressed comments Signed-off-by: bwplotka <bwplotka@gmail.com> --------- Signed-off-by: bwplotka <bwplotka@gmail.com>
wbollock
pushed a commit
to wbollock/prometheus
that referenced
this pull request
Feb 6, 2026
* refactor: switch OTLP handler to AppendableV2 Signed-off-by: bwplotka <bwplotka@gmail.com> * addressed comments Signed-off-by: bwplotka <bwplotka@gmail.com> --------- Signed-off-by: bwplotka <bwplotka@gmail.com>
wbollock
pushed a commit
to wbollock/prometheus
that referenced
this pull request
Feb 6, 2026
* refactor: switch OTLP handler to AppendableV2 Signed-off-by: bwplotka <bwplotka@gmail.com> * addressed comments Signed-off-by: bwplotka <bwplotka@gmail.com> --------- Signed-off-by: bwplotka <bwplotka@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progresses #17632
This PR switched prod OTLP handling to AppenderV2. I will switch otlp* package tests to
teststorage.Appendablein the next PR, couldn't make it now or before the switch.Early benchmarks:
Does this PR introduce a user-facing change?