scrape: switch scrape manager to AppenderV2#17978
Merged
Conversation
Member
Author
|
/prombench main |
Contributor
|
⏱️ Welcome to Prometheus Benchmarking Tool. ⏱️ Compared versions: After the successful deployment (check status here), the benchmarking results can be viewed at: Available Commands:
|
Signed-off-by: bwplotka <bwplotka@gmail.com>
eaccc61 to
8109ba3
Compare
Member
Author
|
IMO it looks great Resources looks good (24h avg) 
CPU sometimes gets higher but max 1.6% avg (last 3h) 
But it depends what unlucky period you see, here is 1.2% less CPU for V2: 
I think the variance (also on query latencies) is still due to prombench load testing is not equal. Here is when V2 is "slower" on queries: 
Here is when V1 is slower: 
Overall, I think we should be good to switch 🎉 |
krajorama
approved these changes
Feb 2, 2026
Member
krajorama
left a comment
There was a problem hiding this comment.
LGTM, measurements look within spec
Member
Author
|
/prombench cancel |
Contributor
|
Benchmark cancel is in progress. |
22 tasks
wbollock
pushed a commit
to wbollock/prometheus
that referenced
this pull request
Feb 6, 2026
Signed-off-by: bwplotka <bwplotka@gmail.com> Signed-off-by: Will Bollock <wbollock@linode.com>
wbollock
pushed a commit
to wbollock/prometheus
that referenced
this pull request
Feb 6, 2026
Signed-off-by: bwplotka <bwplotka@gmail.com>
wbollock
pushed a commit
to wbollock/prometheus
that referenced
this pull request
Feb 6, 2026
Signed-off-by: bwplotka <bwplotka@gmail.com>
wbollock
pushed a commit
to wbollock/prometheus
that referenced
this pull request
Feb 6, 2026
Signed-off-by: bwplotka <bwplotka@gmail.com>
wbollock
pushed a commit
to wbollock/prometheus
that referenced
this pull request
Feb 6, 2026
Signed-off-by: bwplotka <bwplotka@gmail.com>
wbollock
pushed a commit
to wbollock/prometheus
that referenced
this pull request
Feb 6, 2026
Signed-off-by: bwplotka <bwplotka@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #17632
Trying #17959 after fanout fix.
Does this PR introduce a user-facing change?