Makefile.common: Push major version tags to registry#17892
Merged
roidelapluie merged 1 commit intoprometheus:mainfrom Jan 22, 2026
Merged
Makefile.common: Push major version tags to registry#17892roidelapluie merged 1 commit intoprometheus:mainfrom
roidelapluie merged 1 commit intoprometheus:mainfrom
Conversation
In commit 74775d7 "Add major version tag (prometheus#8026)" from 2020, the docker-tag-latest target was updated to create major version tags (v2, v3, etc.) but these tags were never actually pushed to the registry. They existed locally only after tagging but were never published. This commit fixes the issue by: - Adding logic to docker-publish to push major version tags when DOCKER_IMAGE_TAG="latest" (triggered by promci during releases) - Adding logic to docker-manifest to create major version manifests when DOCKER_IMAGE_TAG="latest" Pre-release filtering is handled at the promci level, where the regex check ^v[0-9]+(\.[0-9]+){2}$ already ensures only stable releases trigger the "latest" tagging workflow. Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>
Merged
SuperQ
approved these changes
Jan 22, 2026
|
@roidelapluie @SuperQ Hey folks, after merging the latest "Sync common files" in ipmi-exporter, I get an error publishing artifacts that seems related to this: https://github.com/prometheus-community/ipmi_exporter/actions/runs/22058914370/job/63734029249#step:4:891 Do you happen to know what's going on there? Might well be me holding it wrong, but e/t has worked fine up until now, so not sure what the issue could be... |
Member
Author
|
This is not related to this change: docker/bake-action#322. The issue is the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In commit 74775d7 "Add major version tag (#8026)" from 2020, the docker-tag-latest target was updated to create major version tags (v2, v3, etc.) but these tags were never actually pushed to the registry. They existed locally only after tagging but were never published.
This commit fixes the issue by:
Pre-release filtering is handled at the promci level, where the regex check ^v[0-9]+(.[0-9]+){2}$ already ensures only stable releases trigger the "latest" tagging workflow.
Which issue(s) does the PR fix:
Does this PR introduce a user-facing change?