Build riscv64 docker image by default#17508
Merged
krajorama merged 2 commits intoprometheus:mainfrom Feb 10, 2026
Merged
Conversation
Member
|
Thanks for the PR!
Unclear what you saw; this is the log of Go Tests succeeding: Should it be added to |
Contributor
Author
You can check this CI link: https://github.com/ffgan/prometheus/actions/runs/19192018560/job/54867749156 |
Co-authored by: nijincheng@iscas.ac.cn; Signed-off-by: ffgan <sudoemt@gmail.com>
daccec3 to
39ddf0c
Compare
Contributor
Author
|
Well, after I rebased, this issue disappeared. For details, see https://github.com/ffgan/prometheus/actions/runs/19570609194/job/56042971415 So, perhaps we can consider whether we can merge this PR now. |
Contributor
Author
|
Hi @bboreham. Could you please help review this PR again? I think it should be ready to merge. |
aknuds1
approved these changes
Dec 21, 2025
Contributor
aknuds1
left a comment
There was a problem hiding this comment.
LGTM.
@bboreham I don't see s390x in .promu.yml any longer, even though it was originally added in #4605. Actually I don't see any architectures in .promu.yml, I guess they are no longer necessary in that file.
I can in fact only see the s390x architecture within .dockerignore and Makefile, same approach as this PR follows, so it LGTM.
Member
|
Specific architectures are not needed if they're in the default crossbuild list in promu. This already includes |
SuperQ
reviewed
Dec 21, 2025
Co-authored-by: Ben Kochie <superq@gmail.com> Signed-off-by: ffgan <sudoemt@gmail.com>
SuperQ
approved these changes
Dec 21, 2025
Member
|
Note, this isn't actually needed if you want to build riscv64 locally. This affects our default build and publish pipeline. You can always override the make variable like this: |
Contributor
Author
|
Hi @simonpasquier . Could you please help take a look at this PR? |
bwplotka
added a commit
that referenced
this pull request
Feb 11, 2026
* Update npm dependencies for v3.10 Signed-off-by: Ganesh Vernekar <ganesh.vernekar@reddit.com> * Fix critical npm vulnerabilities with npm audit fix Signed-off-by: Ganesh Vernekar <ganesh.vernekar@reddit.com> * UI: Move HistoryCompleteStrategy into its own file and fix lint Signed-off-by: Ganesh Vernekar <ganesh.vernekar@reddit.com> * [REFACTOR] Relabel: Remove unnecessary Process() function All uses can be replaced by ProcessBuilder, which is more efficient. Signed-off-by: Bryan Boreham <bjboreham@gmail.com> * promql: use Kahan summation for Native Histograms (#15687) As for float samples, Kahan summation is used for the `sum` and `avg` aggregation and for the respective `_over_time` functions. Kahan summation is not perfect. This commit also adds tests that even Kahan summation cannot reliably pass. These tests are commented out. Note that the behavior might be different on other hardware platforms. We have to keep an eye on test failing on other hardware platforms and adjust them accordingly. Signed-off-by: Aleksandr Smirnov <5targazer@mail.ru> * fix(docs): typo in prometheus_agent.md doc Signed-off-by: Mohammad Abbasi <mohammad.v184@gmail.com> * AWS SD: ECS Standalone Tasks The current ECS role in AWS SD assumes that a task is part of a service. This means that tasks that are started as part of AWS Batch will get missed and not be discovered. This changed fixes this so that standalone tasks can be discovered as well. Signed-off-by: matt-gp <small_minority@hotmail.com> * AWS SD: Optmise MSK Role Signed-off-by: matt-gp <small_minority@hotmail.com> * promtool: support missing promql syntax features (#17926) Namely promql-duration-expr and promql-extended-range-selectors. This allows promtool to e.g. check rules files using syntax gated by these features. Signed-off-by: Ian Kerins <git@isk.haus> * Also run CI on release tags Make sure we also run the main CI workflow `v*` release tags so `publish_release` job is run. Signed-off-by: SuperQ <superq@gmail.com> * chore(deps): bump github.com/hashicorp/consul/api from 1.32.0 to 1.33.2 (#17449) Bumps [github.com/hashicorp/consul/api](https://github.com/hashicorp/consul) from 1.32.0 to 1.33.2. - [Release notes](https://github.com/hashicorp/consul/releases) - [Changelog](https://github.com/hashicorp/consul/blob/main/CHANGELOG.md) - [Commits](hashicorp/consul@api/v1.32.0...api/v1.33.2) --- updated-dependencies: - dependency-name: github.com/hashicorp/consul/api dependency-version: 1.33.2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> * AWS SD: Load Region Fallback (#18019) * AWS SD: Load Region Fallback --------- Signed-off-by: matt-gp <small_minority@hotmail.com> * Build riscv64 docker image by default (#17508) * Allow building riscv64 docker image Co-authored by: nijincheng@iscas.ac.cn; Signed-off-by: ffgan <sudoemt@gmail.com> * Update Makefile Co-authored-by: Ben Kochie <superq@gmail.com> Signed-off-by: ffgan <sudoemt@gmail.com> --------- Signed-off-by: ffgan <sudoemt@gmail.com> Co-authored-by: Ben Kochie <superq@gmail.com> * Increase Renovate speed (#18052) * Allow Renovate to run all day on the monthly day. * Increase the max PRs from 10 to 20. * Incresae the PR open rate from 2 to 5. Signed-off-by: SuperQ <superq@gmail.com> * docs(api): clarify metadata vs remote protocols (#17481) Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * tsdb/index: export sentinel error for symbol table size exceeded Signed-off-by: Patryk Prus <p@trykpr.us> * Update Go dependencies for v3.10 release Signed-off-by: Ganesh Vernekar <ganesh.vernekar@reddit.com> * Kubernetes SD: Disable WatchListClient in tests Signed-off-by: Ganesh Vernekar <ganesh.vernekar@reddit.com> * Replace deprecated google.CredentialsFromJSON with option.WithAuthCredentialsFile Signed-off-by: Ganesh Vernekar <ganesh.vernekar@reddit.com> * chore(deps): update actions/checkout action to v4.3.1 (#18054) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update actions/cache action to v5.0.3 (#18053) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update actions/setup-go action to v6.2.0 (#18055) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> --------- Signed-off-by: Ganesh Vernekar <ganesh.vernekar@reddit.com> Signed-off-by: Bryan Boreham <bjboreham@gmail.com> Signed-off-by: Aleksandr Smirnov <5targazer@mail.ru> Signed-off-by: Mohammad Abbasi <mohammad.v184@gmail.com> Signed-off-by: matt-gp <small_minority@hotmail.com> Signed-off-by: Ian Kerins <git@isk.haus> Signed-off-by: SuperQ <superq@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> Signed-off-by: ffgan <sudoemt@gmail.com> Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> Signed-off-by: Patryk Prus <p@trykpr.us> Co-authored-by: Ganesh Vernekar <ganesh.vernekar@reddit.com> Co-authored-by: Bryan Boreham <bjboreham@gmail.com> Co-authored-by: Sasha <103973965+crush-on-anechka@users.noreply.github.com> Co-authored-by: Mohammad Abbasi <mohammad.v184@gmail.com> Co-authored-by: matt-gp <small_minority@hotmail.com> Co-authored-by: Ian Kerins <git@isk.haus> Co-authored-by: SuperQ <superq@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> Co-authored-by: Julien <291750+roidelapluie@users.noreply.github.com> Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com> Co-authored-by: ffgan <sudoemt@gmail.com> Co-authored-by: Patryk Prus <p@trykpr.us> Co-authored-by: Ganesh Vernekar <ganeshvern@gmail.com> Co-authored-by: Joe Adams <github@joeadams.io> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) does the PR fix:
None
Does this PR introduce a user-facing change?
In an x86 environment, riscv64 images can be successfully built using the following commands:
Prometheus itself has good support for riscv64, so it's normal to successfully cross-compile the results here. However, if you run
make buildlocally on riscv64, you may encounter some issues when using Node.js, because Node.js currently does not officially support riscv64, which could lead to problems such as illegal instructions. Nevertheless, these issues are temporarily unrelated to this PR. This PR only focuses on building riscv64 images.I tested the CI in my own fork, and the results are as follows: linux/ppc64le linux/riscv64 linux/s390x
The results show that everything is working normally.
However,
Go testsfailed. I checked the historical CI builds of the current branch, and this appears to be an existing CI issue with the current branch, not a problem introduced by this PR.If there is anything that needs to be supplemented or modified, please feel free to contact me at any time. I'm happy to answer any questions.
Other Info
Co-authored by: nijincheng@iscas.ac.cn;