docs: add use_fips_sts_endpoint to sigv4 config#17304
Merged
jan--f merged 1 commit intoprometheus:mainfrom Nov 7, 2025
Merged
Conversation
Signed-off-by: Devansh Sehgal <devanshsehgal02@gmail.com>
metalmatze
approved these changes
Oct 21, 2025
Member
metalmatze
left a comment
There was a problem hiding this comment.
This code lives within the AWS SDK, right? I can't find a trace in the Prometheus code. If this is what the upstream SDK wants to do, I'm totally fine updating the docs here.
Member
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds
use_fips_sts_endpointto thesigv4block indocs/configuration/configuration.md, including a short description, and minimum version note, The field enables use of the FIPS-compliant AWS STS endpoint when assuming roles.<http_config> → sigv4section in the page.prometheus/common v0.55.0).Rationale / background
Environment variable–based selection (
AWS_USE_FIPS_ENDPOINT) no longer drives STS FIPS usage for this path; the documented way is the config knobuse_fips_sts_endpoint. This closes the docs gap so users can discover the option directly from the Prometheus configuration page.References:
prometheus/commonand consumed by Prometheus in v2.54.0. linkExample
Which issue(s) does the PR fix:
use_fips_sts_endpointto sigv4 documentation. #17301Related
use_fips_sts_endpointin sigv4 config prometheus-operator/prometheus-operator#7987, Allow remote read to not add external labels #7992Does this PR introduce a user-facing change?
Checklist
docs/configuration/configuration.md).git commit -s).sigv4entries.Reviewers to ping (suggested): @roidelapluie @metalmatze