Conversation
|
/prombench v3.2.1 |
|
⏱️ Welcome to Prometheus Benchmarking Tool. ⏱️ Compared versions: After the successful deployment (check status here), the benchmarking results can be viewed at: Available Commands:
|
|
/prombench cancel |
|
Benchmark cancel is in progress. |
|
@ArthurSens in case you don't agree we should backport the whole common bump #16210 to 3.3.1 |
|
|
||
| func init() { | ||
| // This can be removed when the default validation scheme in common is updated. | ||
| //nolint:staticcheck |
There was a problem hiding this comment.
the /commom bump deprecated this
|
/prombench v3.3.0 |
|
⏱️ Welcome to Prometheus Benchmarking Tool. ⏱️ Compared versions: After the successful deployment (check status here), the benchmarking results can be viewed at: Available Commands:
|
|
/prombench cancel |
|
Benchmark cancel is in progress. |
That's totally ok! We've been discussing this deprecation with @bwplotka and @ywwg, we're considering removing the deprecation actually |
Signed-off-by: machine424 <ayoubmrini424@gmail.com>
prometheus/common#746 in order to fix prometheus#16466 it seems acceptable to get the other changes in 0.63.0 as well Signed-off-by: machine424 <ayoubmrini424@gmail.com>
We should use the configured value, or Prometheus' default of 75%, while initializing and loading the WAL. Since the Go default is 100%, most Prometheus users would experience higher memory usage before the value is configured. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
E.g. if a module starting up looks at GOMAXPROCS to size something, we need to have set it already. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
chore: bump github.com/prometheus/common to 0.63.0 to get
prometheus/common#746 in order to fix
#16466
it seems acceptable to get the other changes in 0.63.0
as well