Conversation
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
bwplotka
approved these changes
Mar 13, 2025
Member
|
Thanks! |
github-merge-queue bot
pushed a commit
to open-telemetry/opentelemetry-collector
that referenced
this pull request
Mar 19, 2025
…3.0 (#12656)" (#12673) #### Description Contrib tests are currently failing on main with the following build error: ``` Error: /home/runner/go/pkg/mod/github.com/prometheus/prometheus@v0.300.1/util/logging/file.go:42:23: undefined: promslog.AllowedFormat ``` I believe this is because of the update in #12656: there is [a breaking change in `github.com/prometheus/common` 0.63.0](prometheus/common#754) that is incompatible with the version of `github.com/prometheus` used in some contrib modules. While the latter package [has been updated](prometheus/prometheus#16210) on main, the updated version hasn't been released yet, so I this the only solution is to revert this PR until then.
3 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To unblock #16089
I'm tagging @bwplotka just because you made the breaking change in 0.63. It seems like an easy fix, but I just wanted to make sure.