[FEATURE] PromQL: Implements idelta and irate with histograms#15853
Merged
beorn7 merged 4 commits intoprometheus:mainfrom Jan 31, 2025
Merged
[FEATURE] PromQL: Implements idelta and irate with histograms#15853beorn7 merged 4 commits intoprometheus:mainfrom
idelta and irate with histograms#15853beorn7 merged 4 commits intoprometheus:mainfrom
Conversation
Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>
Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>
beorn7
reviewed
Jan 23, 2025
beorn7
requested changes
Jan 23, 2025
Member
beorn7
left a comment
There was a problem hiding this comment.
Thanks. Looks generally right. I have an idea about the initial management of the "four last samples". And maybe we should allow a result if there are two histograms with incompatible buckets in an irate calculation.
Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>
beorn7
requested changes
Jan 29, 2025
Member
Member
|
I also have to update spec and doc. |
Member
|
Spec update is contained in prometheus/docs#2576 , and after all I think we shouldn't discuss this in the regular PromQL doc. It is super niche and would be very confusing at this place. The spec is the right place to mention it. |
Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>
Contributor
Author
|
@beorn7 I've applied all the suggested changes and this PR is ready for another round of review. |
beorn7
approved these changes
Jan 31, 2025
Member
beorn7
left a comment
There was a problem hiding this comment.
Thank you very much, looks beautiful now.
charleskorn
added a commit
to grafana/mimir
that referenced
this pull request
Mar 11, 2025
charleskorn
added a commit
to grafana/mimir
that referenced
this pull request
Mar 11, 2025
charleskorn
added a commit
to grafana/mimir
that referenced
this pull request
Mar 12, 2025
* Upgrade mimir-prometheus * Bring in upstream test changes * Apply change to match prometheus/prometheus#15974 * Remove test case added in upstream in prometheus/prometheus#15975 * Add tests for case where range vector selectors and subqueries have 0 range Brings in change from #10586 * Update `sort` and `sort_desc` behaviour to match prometheus/prometheus#15964 * Add support for native histograms to `irate` and `idelta` to match prometheus/prometheus#15853 * Adjust test cases to match support for native histograms in `irate` and `idelta` * Change binop annotations to match behaviour in prometheus/prometheus#15895 * Ignore incompatible schemas between the first and second point in `rate` and `increase` if the second point is a reset (prometheus/prometheus#15902) * Adjust annotation test cases to match new behaviour introduced in previous commit * Disable tests failing due to prometheus/prometheus#16199 * Add changelog entry * Update `TestQuerySharding_FunctionCorrectness` to reflect changes in prometheus/prometheus#15964
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #13934
This PR implements
irateandideltafor histogram samples.