Use custom annotation for histogram quantile monotonicity info to provide more details#15578
Conversation
|
Tagging @beorn7 and @krajorama because you reviewed the original PR |
a53547f to
9d0f396
Compare
9d0f396 to
1c4b9b0
Compare
|
Test failure seems unrelated to this PR, could be flaky |
8852ccf to
8cf3a0d
Compare
|
I already sneak-peeked a bit here. But let's first get #15577 merged and this rebased before I do the detailed review here. In the meantime, could you update the PR description to include a changelog line for the user facing changes? (This is a recently added requirement that also has a CI test, which is now red for this PR.) It looks like this: |
|
OK, now this needs a rebase, and then I'll review it ASAP. |
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
…specific Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
8cf3a0d to
bf62062
Compare
|
@beorn7 rebased! |
beorn7
left a comment
There was a problem hiding this comment.
Looks great. Just cosmetic notes about variable naming (which you are free to disagree with).
|
Note about the failing test: I'm pretty sure it's unrelated to this PR. I'm trying to re-run it, but it has now failed twice in a row already. :( |
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
beorn7
left a comment
There was a problem hiding this comment.
Great. We are finally done. Thank you very much.
…vide more details (prometheus#15578) Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com> Signed-off-by: Will Bollock <wbollock@linode.com>
…vide more details (prometheus#15578) Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
…vide more details (prometheus#15578) Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
…vide more details (prometheus#15578) Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
…vide more details (prometheus#15578) Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
…vide more details (prometheus#15578) Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
Depends on #15577 which is now merged so this is ready.
Adds more details to the histogram quantile monotonicity info annotation, e.g. min and max timestamps, upper bounds of the min and max buckets affected, number of samples affected, max diff found:
PromQL info: input to histogram_quantile needed to be fixed for monotonicity (see https://prometheus.io/docs/prometheus/latest/querying/functions/#histogram_quantile) for metric name "series_1", from buckets 2.5 to 100, with a max diff of 10, over 3 samples from 2023-12-25T00:00:00Z to 2024-12-25T00:00:00Z (1:4)Supersedes #14339