Implement json encoder/decoder for regexp#15383
Merged
aknuds1 merged 3 commits intoprometheus:mainfrom Nov 24, 2024
Merged
Conversation
Signed-off-by: Ben Ye <benye@amazon.com>
bboreham
reviewed
Nov 12, 2024
Member
bboreham
left a comment
There was a problem hiding this comment.
Do we really want JSON to be inconsistent from YAML?
In YAML we just give the string; your PR has a sub-field regex:.
Also I am wondering why Config doesn't need anything extra to marshal JSON.
Signed-off-by: Ben Ye <benye@amazon.com>
Contributor
Author
|
@bboreham Thanks I fixed the implementation. Also added json tags. |
aknuds1
reviewed
Nov 24, 2024
Signed-off-by: Ben Ye <benye@amazon.com>
|
FYI: this broke the draft implementation I had for #8511 |
muff1nman
added a commit
to muff1nman/prometheus
that referenced
this pull request
May 16, 2025
This reverts commit 872e2db.
Member
I also am running into a use case where I want to get back a relabel config through the API (a new API endpoint for analyzing relabeling steps in the UI), and the JSON encoding differing from the YAML field names is disruptive. I would have to un-camelcase the field names in the UI again to show the original names. Maybe translating existing well-known config field names into camelCase isn't the best thing to do here after all? @yeya24 How much would it hurt you (or Thanos) if this was changed back to the original field names in JSON output? |
juliusv
added a commit
that referenced
this pull request
Oct 15, 2025
This adds: * A `ScrapePoolConfig()` method to the scrape manager that allows getting the scrape config for a given pool. * An API endpoint at `/api/v1/targets/relabel_steps` that takes a pool name and a label set of a target and returns a detailed list of applied relabeling rules and their output for each step. * A "show relabeling" link/button for each target on the discovery page that shows the detailed flow of all relabeling rules (based on the API response) for that target. Note that this changes the JSON encoding of the relabeling rule config struct to output the original snake_case (instead of camelCase) field names, and before merging, we need to be sure that's ok :) See my comment about that at #15383 (comment) Fixes #17283 Signed-off-by: Julius Volz <julius.volz@gmail.com>
juliusv
added a commit
that referenced
this pull request
Oct 15, 2025
This adds: * A `ScrapePoolConfig()` method to the scrape manager that allows getting the scrape config for a given pool. * An API endpoint at `/api/v1/targets/relabel_steps` that takes a pool name and a label set of a target and returns a detailed list of applied relabeling rules and their output for each step. * A "show relabeling" link/button for each target on the discovery page that shows the detailed flow of all relabeling rules (based on the API response) for that target. Note that this changes the JSON encoding of the relabeling rule config struct to output the original snake_case (instead of camelCase) field names, and before merging, we need to be sure that's ok :) See my comment about that at #15383 (comment) Fixes #17283 Signed-off-by: Julius Volz <julius.volz@gmail.com>
juliusv
added a commit
that referenced
this pull request
Oct 15, 2025
This adds: * A `ScrapePoolConfig()` method to the scrape manager that allows getting the scrape config for a given pool. * An API endpoint at `/api/v1/targets/relabel_steps` that takes a pool name and a label set of a target and returns a detailed list of applied relabeling rules and their output for each step. * A "show relabeling" link/button for each target on the discovery page that shows the detailed flow of all relabeling rules (based on the API response) for that target. Note that this changes the JSON encoding of the relabeling rule config struct to output the original snake_case (instead of camelCase) field names, and before merging, we need to be sure that's ok :) See my comment about that at #15383 (comment) Fixes #17283 Signed-off-by: Julius Volz <julius.volz@gmail.com>
muff1nman
added a commit
to muff1nman/prometheus
that referenced
this pull request
Mar 4, 2026
This reverts commit 872e2db.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a usecase in Thanos where we need to marshal
relabel.Configto JSON and store in Thanos metadata file. This PR implements the corresponding JSON encoding and decoding function forRegexp. Otherwise it causes panic.This should fix thanos-io/thanos#7844.