fix(nhcb): do not return nhcb from parse if exponential is present#15209
Merged
fix(nhcb): do not return nhcb from parse if exponential is present#15209
Conversation
eb147bc to
a18042a
Compare
From: #14978 (comment) Also encode the requirement table set in #13532 Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
a18042a to
8e607d9
Compare
jesusvazquez
approved these changes
Oct 24, 2024
Member
jesusvazquez
left a comment
There was a problem hiding this comment.
LGTM! Very clear code to me
krajorama
commented
Oct 24, 2024
| {Labels: labels.FromStrings("id", "something-test"), Value: 0.5}, | ||
| {Labels: labels.FromStrings("id", "something-test"), Value: 8.0}, | ||
| }, | ||
| // TODO(krajorama): ct: int64p(1520430001000), |
Member
Author
There was a problem hiding this comment.
note to reviewers: input doesn't have created timestamp, copy paste error to have this comment.
krajorama
commented
Oct 24, 2024
| {Labels: labels.FromStrings("id", "something-test"), Value: 0.0, HasTs: true, Ts: 123321}, | ||
| {Labels: labels.FromStrings("id", "something-test"), Value: 2e100, HasTs: true, Ts: 123000}, | ||
| }, | ||
| // TODO(krajorama): ct: int64p(1520430002000), |
Member
Author
There was a problem hiding this comment.
note to reviewers: input doesn't have created timestamp, copy paste error to have this comment.
julienduchesne
pushed a commit
to julienduchesne/prometheus
that referenced
this pull request
Dec 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From: #14978 (comment)
Also encode the requirement table set in #13532
This relies on protobuf parser exposing native histograms before classic series and that text format exposers follow the requirement about ordering: proposals/2024-01-29_native_histograms_text_format.md.