textparse: Refactored main testing utils for reusability; fixed proto Units.#15095
Merged
textparse: Refactored main testing utils for reusability; fixed proto Units.#15095
Conversation
4604fc8 to
851f7c3
Compare
851f7c3 to
5da85a6
Compare
ArthurSens
reviewed
Oct 4, 2024
f93f38c to
20169ca
Compare
20169ca to
72cf70e
Compare
… Units. Signed-off-by: bwplotka <bwplotka@gmail.com>
72cf70e to
0a8a5f6
Compare
Member
|
So this is a bugfix - we were never receiving units from protobuf scrapes? |
Merged
squat
pushed a commit
to squat/prometheus
that referenced
this pull request
Nov 8, 2024
… Units. (prometheus#15095) Signed-off-by: bwplotka <bwplotka@gmail.com>
squat
pushed a commit
to squat/prometheus
that referenced
this pull request
Nov 8, 2024
… Units. (prometheus#15095) Signed-off-by: bwplotka <bwplotka@gmail.com>
squat
pushed a commit
to squat/prometheus
that referenced
this pull request
Nov 8, 2024
… Units. (prometheus#15095) Signed-off-by: bwplotka <bwplotka@gmail.com>
squat
pushed a commit
to squat/prometheus
that referenced
this pull request
Nov 25, 2024
… Units. (prometheus#15095) Signed-off-by: bwplotka <bwplotka@gmail.com>
julienduchesne
pushed a commit
to julienduchesne/prometheus
that referenced
this pull request
Dec 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This centralizes the parsing testing in one, composable space. Already found bug in proto parser thanks to that (Next never sets entry to
Unit) cc @beorn7 @krajorama - hope fixing this in this refactor is ok (minor fix).This is to make sure we can reuse same parsing test e.g. as we iterate on #14965 cc @Maniktherana @ArthurSens