Skip to content

storage: require selectors to always return matching results#15092

Merged
beorn7 merged 1 commit intoprometheus:mainfrom
jan--f:clarify-storage-contract
Oct 9, 2024
Merged

storage: require selectors to always return matching results#15092
beorn7 merged 1 commit intoprometheus:mainfrom
jan--f:clarify-storage-contract

Conversation

@jan--f
Copy link
Contributor

@jan--f jan--f commented Oct 4, 2024

This seeks to address #13586.

Does the ExemplarQuerier interface need a similar hint?

Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
@jan--f jan--f requested review from beorn7 and bwplotka October 4, 2024 10:12
Copy link
Member

@beorn7 beorn7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much.

@beorn7 beorn7 merged commit 5e987e7 into prometheus:main Oct 9, 2024
@beorn7 beorn7 mentioned this pull request Oct 9, 2024
julienduchesne pushed a commit to julienduchesne/prometheus that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants