Conversation
35ca2a6 to
4529a84
Compare
Member
Author
|
cc @krajorama as it will be useful for nhcb work too 🤗 |
Signed-off-by: bwplotka <bwplotka@gmail.com>
Signed-off-by: bwplotka <bwplotka@gmail.com>
4529a84 to
b24d0af
Compare
Signed-off-by: bwplotka <bwplotka@gmail.com>
squat
pushed a commit
to squat/prometheus
that referenced
this pull request
Nov 8, 2024
* textparse: Refactored benchmark. Signed-off-by: bwplotka <bwplotka@gmail.com> * Kill sinks, tested, nothing is inlined. Signed-off-by: bwplotka <bwplotka@gmail.com> * Addressed comments. Signed-off-by: bwplotka <bwplotka@gmail.com> --------- Signed-off-by: bwplotka <bwplotka@gmail.com>
squat
pushed a commit
to squat/prometheus
that referenced
this pull request
Nov 8, 2024
* textparse: Refactored benchmark. Signed-off-by: bwplotka <bwplotka@gmail.com> * Kill sinks, tested, nothing is inlined. Signed-off-by: bwplotka <bwplotka@gmail.com> * Addressed comments. Signed-off-by: bwplotka <bwplotka@gmail.com> --------- Signed-off-by: bwplotka <bwplotka@gmail.com>
squat
pushed a commit
to squat/prometheus
that referenced
this pull request
Nov 8, 2024
* textparse: Refactored benchmark. Signed-off-by: bwplotka <bwplotka@gmail.com> * Kill sinks, tested, nothing is inlined. Signed-off-by: bwplotka <bwplotka@gmail.com> * Addressed comments. Signed-off-by: bwplotka <bwplotka@gmail.com> --------- Signed-off-by: bwplotka <bwplotka@gmail.com>
squat
pushed a commit
to squat/prometheus
that referenced
this pull request
Nov 25, 2024
* textparse: Refactored benchmark. Signed-off-by: bwplotka <bwplotka@gmail.com> * Kill sinks, tested, nothing is inlined. Signed-off-by: bwplotka <bwplotka@gmail.com> * Addressed comments. Signed-off-by: bwplotka <bwplotka@gmail.com> --------- Signed-off-by: bwplotka <bwplotka@gmail.com>
julienduchesne
pushed a commit
to julienduchesne/prometheus
that referenced
this pull request
Dec 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For more realistic benchmarks to iterate over proto improvements we planned, #14965 and perhaps experimenting with CI use with https://github.com/benchmark-action/github-action-benchmark or so, I propose a refactor of the benchmark we want to persist in our
textparsepackage.To me we want to persist useful stuff to iterate on, but more importantly, something anyone should run before commiting new changes. For this reasons I killed those isolated cases for series, CT, series+metrics, series+metrics reuse. Instead we only have benchmark for realistic use of parser (as we use in
scrape.append) AND opt-in (skipped by default) expfmt comparison. Anyone can comment out certain methods for local testing and comparisons.Additionally:
Would love to know your opinion @beorn7 and @bboreham on this 🤗
Here is an example of what this benchmark enables us to do #14965 (comment)