Adding small test update for temp dir using t.TempDir#13293
Merged
jesusvazquez merged 2 commits intoprometheus:mainfrom Dec 28, 2023
Merged
Adding small test update for temp dir using t.TempDir#13293jesusvazquez merged 2 commits intoprometheus:mainfrom
jesusvazquez merged 2 commits intoprometheus:mainfrom
Conversation
Contributor
Author
|
Im also pinging @beorn7 , for review if possible |
promql/engine_test.go
Outdated
| require.NoError(t, err) | ||
| defer os.RemoveAll(dir) | ||
| dir := t.TempDir() | ||
| t.Cleanup(func() { |
Member
There was a problem hiding this comment.
t.TempDir() TempDir returns a temporary directory for the test to use. The directory is automatically removed by Cleanup when the test and all its subtests complete.
Suggested change
| t.Cleanup(func() { |
Contributor
Author
There was a problem hiding this comment.
@roidelapluie thank you for the explanation, all make sense, I will update pr
Signed-off-by: Mile Druzijanic <miledruz@gmail.com> Signed-off-by: Mile Druzijanic <zedsprogramms@gmail.com>
Signed-off-by: Mile Druzijanic <zedsprogramms@gmail.com>
1ffe445 to
1620867
Compare
jesusvazquez
approved these changes
Dec 28, 2023
Member
jesusvazquez
left a comment
There was a problem hiding this comment.
LGTM Thank you for your contribution
bboreham
reviewed
Dec 30, 2023
| }) | ||
|
|
||
| tmpdir := t.TempDir() | ||
|
|
Member
There was a problem hiding this comment.
FYI this is a line consisting only of tabs, which fails current linting rules.
Member
|
I think I will revert this change until we sort out what has gone wrong. |
bboreham
added a commit
that referenced
this pull request
Dec 30, 2023
This reverts commit 2ddb359. Various tests are failing in CI after this change; reverting to free up other work.
bboreham
added a commit
that referenced
this pull request
Dec 30, 2023
This reverts commit 2ddb359. Various tests are failing in CI after this change; reverting to free up other work. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
bboreham
added a commit
that referenced
this pull request
Dec 30, 2023
Revert "Adding small test update for temp dir using t.TempDir (#13293)"
fbegyn
pushed a commit
to fbegyn/prometheus
that referenced
this pull request
Jul 11, 2024
* Adding small test update for temp dir using t.TempDir Signed-off-by: Mile Druzijanic <miledruz@gmail.com> Signed-off-by: Mile Druzijanic <zedsprogramms@gmail.com> * removing not required cleanup Signed-off-by: Mile Druzijanic <zedsprogramms@gmail.com> --------- Signed-off-by: Mile Druzijanic <miledruz@gmail.com> Signed-off-by: Mile Druzijanic <zedsprogramms@gmail.com>
fbegyn
pushed a commit
to fbegyn/prometheus
that referenced
this pull request
Jul 11, 2024
…heus#13293)" This reverts commit 2ddb359. Various tests are failing in CI after this change; reverting to free up other work. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a little fix update for this issue:
#9594
Use case. Why is this important?
Error handling is implicit.
Cleanup is implicit.