scrape: Added trackTimestampsStaleness configuration option#13066
Merged
LeviHarrison merged 1 commit intorelease-2.48from Nov 2, 2023
Merged
scrape: Added trackTimestampsStaleness configuration option#13066LeviHarrison merged 1 commit intorelease-2.48from
LeviHarrison merged 1 commit intorelease-2.48from
Conversation
Add the ability to track staleness when an explicit timestamp is set. Useful for cAdvisor. Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
3cf9457 to
fed6f81
Compare
Contributor
|
I'm not familiar with the context of this PR, so I was wondering if it was a critical enough fix to make 2.48, which has already been cut and is in release candidates. |
Member
|
Hello, let's have it in 2.48. I discussed with Ben. |
LeviHarrison
approved these changes
Nov 1, 2023
Contributor
LeviHarrison
left a comment
There was a problem hiding this comment.
Alright, LGTM then.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry pick #13060
Add the ability to track staleness when an explicit timestamp is set. Useful for cAdvisor.