scrape: Added trackTimestampsStaleness configuration option#13060
Merged
roidelapluie merged 1 commit intoprometheus:mainfrom Oct 31, 2023
Merged
scrape: Added trackTimestampsStaleness configuration option#13060roidelapluie merged 1 commit intoprometheus:mainfrom
roidelapluie merged 1 commit intoprometheus:mainfrom
Conversation
Add the ability to track staleness when an explicit timestamp is set. Useful for cAdvisor. Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
SuperQ
approved these changes
Oct 31, 2023
Member
SuperQ
left a comment
There was a problem hiding this comment.
Awesome, this will be very good for cAdvisor users.
Comment on lines
+229
to
+230
| # inserted in the TSDB when a metric is no longer present or the target | ||
| # is down. |
Member
There was a problem hiding this comment.
Are there any other cases where we would/wouldn't insert a staleness marker?
Member
Author
There was a problem hiding this comment.
no. do you think we should improve the wording?
Member
There was a problem hiding this comment.
No, wording is fine. I was just wondering if we had an exception to these.
Contributor
|
Awesome, thanks! |
This was referenced Nov 1, 2023
roidelapluie
pushed a commit
to roidelapluie/prometheus
that referenced
this pull request
Nov 9, 2023
This commit introduces an additional test in `scrape_test.go` to verify staleness tracking when `trackTimestampStaleness` is enabled. The new `TestScrapeLoopAppendStalenessIfTrackTimestampStaleness` function asserts that the scrape loop correctly appends staleness markers when necessary, reflecting the expected behavior with the feature flag turned on. The previous tests were only testing end of scrape staleness. Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
roidelapluie
pushed a commit
to roidelapluie/prometheus
that referenced
this pull request
Nov 9, 2023
This commit introduces an additional test in `scrape_test.go` to verify staleness tracking when `trackTimestampStaleness` is enabled. The new `TestScrapeLoopAppendStalenessIfTrackTimestampStaleness` function asserts that the scrape loop correctly appends staleness markers when necessary, reflecting the expected behavior with the feature flag turned on. The previous tests were only testing end of scrape staleness. Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
roidelapluie
pushed a commit
that referenced
this pull request
Nov 9, 2023
Follow-up to #13060: Add test to ensure staleness tracking
Merged
5 tasks
bboreham
pushed a commit
to grafana/agent
that referenced
this pull request
Feb 6, 2024
Added upstream 4 months ago: prometheus/prometheus#13060
bboreham
pushed a commit
to grafana/agent
that referenced
this pull request
Feb 6, 2024
Added upstream 4 months ago: prometheus/prometheus#13060
3 tasks
rfratto
pushed a commit
to grafana/agent
that referenced
this pull request
Feb 6, 2024
Added upstream 4 months ago: prometheus/prometheus#13060 Co-authored-by: Paulin Todev <paulin.todev@gmail.com>
BarunKGP
pushed a commit
to BarunKGP/grafana-agent
that referenced
this pull request
Feb 20, 2024
Added upstream 4 months ago: prometheus/prometheus#13060 Co-authored-by: Paulin Todev <paulin.todev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the ability to track staleness when an explicit timestamp is set. Useful for cAdvisor.
fixes #11565