Build: remove -a from build to speed up rebuilds#13026
Merged
bboreham merged 1 commit intoprometheus:mainfrom Oct 25, 2023
Merged
Build: remove -a from build to speed up rebuilds#13026bboreham merged 1 commit intoprometheus:mainfrom
bboreham merged 1 commit intoprometheus:mainfrom
Conversation
I think this is a hold-over from when Go was less careful about separating architectures. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
SuperQ
approved these changes
Oct 24, 2023
Member
SuperQ
left a comment
There was a problem hiding this comment.
If this works well, we should update all of our promu configs.
beorn7
approved these changes
Oct 25, 2023
bboreham
added a commit
to bboreham/prometheus
that referenced
this pull request
Oct 31, 2023
I think this is a hold-over from when Go was less careful about separating architectures. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this is a hold-over from when Go was less careful about separating architectures.
make buildis about 3 minutes with this option and 1 minute without, on my desktop computer.