remote-write: respect Retry-After header on 5xx errors#12677
Merged
bboreham merged 3 commits intoprometheus:mainfrom Sep 20, 2023
Merged
remote-write: respect Retry-After header on 5xx errors#12677bboreham merged 3 commits intoprometheus:mainfrom
bboreham merged 3 commits intoprometheus:mainfrom
Conversation
Member
|
👍 fine by me, can we update a test similar to |
Contributor
|
I created a PR to @bboreham's branch with a refactor of the test and an additional test case for the HTTP 500 retry: bboreham#2 |
If the server sent it to us, we should assume it knows better than we do and respect it. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
The new version features a set of test cases that simplify the addition of new HTTP status codes. Signed-off-by: William Dumont <william.dumont@grafana.com>
and compare the retryAfter values. Signed-off-by: William Dumont <william.dumont@grafana.com>
4660973 to
ce6ad15
Compare
Member
Author
|
I have included William's test (thanks!) and rebased. |
tpaschalis
pushed a commit
to grafana/prometheus
that referenced
this pull request
Oct 2, 2023
remote-write: respect Retry-After header on 5xx errors
tpaschalis
pushed a commit
to grafana/prometheus
that referenced
this pull request
Oct 3, 2023
remote-write: respect Retry-After header on 5xx errors
tpaschalis
pushed a commit
to grafana/prometheus
that referenced
this pull request
Oct 11, 2023
remote-write: respect Retry-After header on 5xx errors (cherry picked from commit 2b77ad4)
tpaschalis
pushed a commit
to grafana/prometheus
that referenced
this pull request
Oct 16, 2023
remote-write: respect Retry-After header on 5xx errors (cherry picked from commit 2b77ad4)
demoj1
reviewed
Nov 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the server sent it to us, we should assume it knows better than we do and respect it.
Fixes #12674