Upgrade to github.com/Azure/azure-sdk-for-go/sdk#11860
Upgrade to github.com/Azure/azure-sdk-for-go/sdk#11860LeviHarrison merged 1 commit intoprometheus:mainfrom mmorel-35:azure-sdk-for-go
Conversation
|
I'm having a look at this in preparation for the next release. https://github.com/Azure/azure-sdk-for-go/blob/main/documentation/MIGRATION_GUIDE.md |
kakkoyun
left a comment
There was a problem hiding this comment.
AFAIT, this looks good to me.
I'm not an expert on Azure expert, nor I've ever used it. However, according to the document that I've linked above. Everything looks fine.
|
Did anyone had a chance to test it @mmorel-35? There are no automated tests against Azure, so it would nice to at least run it. Have you been able to check it @mmorel-35 maybe? 🤗 |
bwplotka
left a comment
There was a problem hiding this comment.
Double checked with https://github.com/Azure/go-autorest/blob/main/autorest/azure/environments.go#L34 - all looks solid. Thanks!
Have you tested it?
|
Hi @bwplotka ! I don't have any azure account so I don't have any way to check it with an integration test. |
|
No, we rely for contributors for some pieces like this, sorry! I will announce on -developer list and Twitter, that we need someone to test this PR. Do you mind resolving go.mod? |
|
This needs a rebase. Have we found a way to test this? |
|
Hi @kakkoyun ,
Done !
Not to my knowledge |
|
Hi all, I have a VS Code Enterprise licence which includes a personal MPN subscription. (with an budget of 130€) I'm interest into testing this PR. Are there integration tests to run? Are they instructions which tests should be done manually? I'm also on the CNCF slack. |
|
To clarify, there is no specific set of tests that we need done; we just need someone to say "I use Azure; I tried this out and it worked for me". |
LeviHarrison
left a comment
There was a problem hiding this comment.
Tested and looks good 👍🏻
|
Just need a rebase here and I think we'll be good to go |
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
|
Hi @LeviHarrison , |
|
Thanks for fixing that so fast! This is really helpful for the new release. |
Signed-off-by: Levi Harrison <git@leviharrison.dev>
Signed-off-by: Levi Harrison <git@leviharrison.dev>
Signed-off-by: Levi Harrison <git@leviharrison.dev>
Signed-off-by: Levi Harrison <git@leviharrison.dev>
|
Looks like this PR breaks VMSS discovery #13245 |
I had troubles with my commits signature so I recreated this branch with everything merged.
Replaces #11849
Fixes #10942
xref: https://github.com/Azure/azure-sdk-for-go/blob/main/documentation/MIGRATION_GUIDE.md
Signed-off-by: Matthieu MOREL matthieu.morel35@gmail.com