tsdb: turn off transaction isolation for head compaction#11317
Merged
codesome merged 4 commits intoprometheus:mainfrom Sep 27, 2022
Merged
tsdb: turn off transaction isolation for head compaction#11317codesome merged 4 commits intoprometheus:mainfrom
codesome merged 4 commits intoprometheus:mainfrom
Conversation
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
So that we can see when appending has moved past a certain point in time. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
This will be used when for head compaction. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
68ededf to
341a51d
Compare
Member
Author
|
CI failing on Windows only: It seems to have read more data than was written? |
This saves a lot of work tracking appends done while compaction is ongoing. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
341a51d to
7b62131
Compare
Member
Author
|
I did a |
SuperQ
approved these changes
Sep 20, 2022
Member
SuperQ
left a comment
There was a problem hiding this comment.
I think this will have a very big impact on some of our instances that fall over into a memory death spiral.
Member
codesome
approved these changes
Sep 27, 2022
Member
Author
|
This was the result on one of the production systems at my work: memory usage dropped by half. |
roidelapluie
pushed a commit
to roidelapluie/prometheus
that referenced
this pull request
Nov 23, 2022
…11317) * tsdb: add a basic test for read/write isolation * tsdb: store the min time with isolationAppender So that we can see when appending has moved past a certain point in time. * tsdb: allow RangeHead to have isolation disabled This will be used when for head compaction. * tsdb: do head compaction with isolation disabled This saves a lot of work tracking appends done while compaction is ongoing. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This saves a lot of work tracking appends done while compaction is ongoing.
head.compactable()ensures that the end of the compaction range is more than chunkRange/2 back from now, andhead.appendableMinValidTime()ensures that no new appends can start within the compaction range.We do need to wait for any overlapping appenders that started previously to finish.
Fixes #9253.