tsdb: remove chunkRange and oooCapMax from memSeries#11288
Merged
codesome merged 3 commits intoprometheus:mainfrom Sep 27, 2022
Merged
tsdb: remove chunkRange and oooCapMax from memSeries#11288codesome merged 3 commits intoprometheus:mainfrom
codesome merged 3 commits intoprometheus:mainfrom
Conversation
e819548 to
5097cd5
Compare
Member
|
I guess it is time for a rebase 👀, thanks for both the PRs! |
5097cd5 to
6df63a2
Compare
chunkRange is the (oddly-named) configured duration for the head block. We don't need a copy of this value per series. Pass it down where required, and remove the copy. The value in `Head` is only updated in `resetInMemoryState()`, which also discards all `memSeries`. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
oooCapMax is the configured maximum capacity for an out-of-order chunk. Storing it per-series uses extra memory, and has surprising behaviour if users change the value in config - series created before the change will keep their old value. Instead, pass it down where required, and remove the per-series value. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
6df63a2 to
cf439e7
Compare
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chunkRangeis the (oddly-named) configured duration for the head block.We don't need a copy of this value per series. Pass it down where required, and remove the copy.
The value in
Headis only updated inresetInMemoryState(), which also discards allmemSeries.Similar to #11280.
Also removed
oooCapMaxfor similar reasons.