tsdb: remove chunk pool from memSeries#11280
Merged
codesome merged 1 commit intoprometheus:mainfrom Sep 15, 2022
Merged
Conversation
The chunk pool belongs to the head not to the series. Pass it down where required, and remove the copy of the pointer that `memSeries` was holding. `safeChunk` also needs to hold it, because in scenarios where it is used we don't have a reference to the head. However it was already holding `chunkDiskMapper` for the same reason, so no big change. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
This was referenced Sep 8, 2022
codesome
approved these changes
Sep 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chunk pool belongs to the head not to the series. Pass it down where required, and remove the copy of the pointer that
memSerieswas holding.Since there can be millions of
memSeriesstructs (one for each timeseries in memory), it should not carry stuff it doesn't need.safeChunkalso needs to hold a reference to the pool, because in scenarios where it is used we don't have a reference to the head. However it was already holdingchunkDiskMapperfor the same reason, so no big change.