-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Closed
prometheus/common
#490Description
Description
procfs' golangci-lint.yml workflow currently runs with write-all permissions. This is dangerous, since it opens the project up to supply-chain attacks. GitHub itself recommends ensuring workflows run with minimal permissions.
I've taken a look at the workflow and it doesn't seem to need anything other than read permissions to the repository.
This issue can be solved in two ways:
- add top-level read-only permissions to the workflow; and/or
- set the default token permissions to read-only in the repo settings.
I'll be sending a PR along with this issue that sets the top-level permissions. If you instead (or also) wish to modify the default token permissions:
- Open the repo settings
- Go to Actions > General
- Under "Workflow permissions", set them to "Read repository contents and packages permissions"
Disclosure: My name is Pedro and I work with Google and the Open Source Security Foundation (OpenSSF) to improve the supply-chain security of the open-source ecosystem.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels