Add read-only token permissions#490
Merged
discordianfish merged 1 commit intoprometheus:mainfrom Sep 13, 2023
Merged
Conversation
Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
Contributor
Author
|
Hey, are there any changes you'd like to see on this policy? |
Member
|
Technically @roidelapluie needs to approve this first |
Member
|
LGTM |
Contributor
Author
|
Thanks for merging this! However, I just noticed that Also, the prometheus/prometheus version seems to be more up-to-date than this one (it runs Go 1.54.2, while here it's on 1.51.2, for example). I also noticed that prometheus/procfs just received an update to its |
Member
|
Uhmm.. good question, I assumed this is the source of truth but might be out of the loop a bit - @roidelapluie? |
Closed
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes prometheus/prometheus#12379.
As mentioned there, this PR ensures the golangci-lint workflow always runs with read-only permissions, protecting the projects that use it from supply-chain attacks.
This PR was originally submitted as prometheus/procfs#525, but following @discordianfish's suggestion there, I'm re-submitting it here.