chore: Use kernel-compliant types for {U,G}IDs#620
Merged
SuperQ merged 1 commit intoprometheus:masterfrom Apr 14, 2024
Merged
Conversation
discordianfish
approved these changes
Mar 23, 2024
Member
discordianfish
left a comment
There was a problem hiding this comment.
Beside failing tests, LGTM
As defined in the `torvalds/linux` git tree, `uidgid_types.h`: https://github.com/torvalds/linux/blob/8e938e39866920ddc266898e6ae1fffc5c8f51aa/include/linux/uidgid_types.h#L8 Fixes: prometheus#372 Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod
commented
Mar 30, 2024
Comment on lines
+817
to
+818
| Uid: 0 0 0 0 | ||
| Gid: 0 0 0 0 |
Contributor
Author
There was a problem hiding this comment.
s/spaces/tabs
Lines 642 to 643 in 7b6eccc
|
I would be happy if this PR could be merged :) I am looking forward to that as well. |
SuperQ
approved these changes
Apr 14, 2024
codeboten
referenced
this pull request
in open-telemetry/opentelemetry-collector-contrib
Apr 23, 2024
) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/procfs](https://togithub.com/prometheus/procfs) | `v0.13.0` -> `v0.14.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>prometheus/procfs (github.com/prometheus/procfs)</summary> ### [`v0.14.0`](https://togithub.com/prometheus/procfs/releases/tag/v0.14.0) [Compare Source](https://togithub.com/prometheus/procfs/compare/v0.13.0...v0.14.0) #### What's Changed - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/procfs/pull/613](https://togithub.com/prometheus/procfs/pull/613) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/procfs/pull/615](https://togithub.com/prometheus/procfs/pull/615) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/procfs/pull/616](https://togithub.com/prometheus/procfs/pull/616) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/procfs/pull/621](https://togithub.com/prometheus/procfs/pull/621) - Revert add avgRTT to nfs mountstats [#​487](https://togithub.com/prometheus/procfs/issues/487) by [@​SuperQ](https://togithub.com/SuperQ) in [https://github.com/prometheus/procfs/pull/625](https://togithub.com/prometheus/procfs/pull/625) - style: returns procfs build-in error like other parsing methods by [@​weidongkl](https://togithub.com/weidongkl) in [https://github.com/prometheus/procfs/pull/630](https://togithub.com/prometheus/procfs/pull/630) - update MAINTAINERS.md by [@​pgier](https://togithub.com/pgier) in [https://github.com/prometheus/procfs/pull/629](https://togithub.com/prometheus/procfs/pull/629) - \*: `s/(%v|%s)/%w` and use `go1.20` by [@​rexagod](https://togithub.com/rexagod) in [https://github.com/prometheus/procfs/pull/617](https://togithub.com/prometheus/procfs/pull/617) - chore: Use kernel-compliant types for `{U,G}IDs` by [@​rexagod](https://togithub.com/rexagod) in [https://github.com/prometheus/procfs/pull/620](https://togithub.com/prometheus/procfs/pull/620) - Update Go versions by [@​SuperQ](https://togithub.com/SuperQ) in [https://github.com/prometheus/procfs/pull/632](https://togithub.com/prometheus/procfs/pull/632) - fix: same TCP connection appears twice by [@​weidongkl](https://togithub.com/weidongkl) in [https://github.com/prometheus/procfs/pull/631](https://togithub.com/prometheus/procfs/pull/631) - Revert "fix: same TCP connection appears twice" by [@​SuperQ](https://togithub.com/SuperQ) in [https://github.com/prometheus/procfs/pull/633](https://togithub.com/prometheus/procfs/pull/633) #### New Contributors - [@​rexagod](https://togithub.com/rexagod) made their first contribution in [https://github.com/prometheus/procfs/pull/617](https://togithub.com/prometheus/procfs/pull/617) **Full Changelog**: prometheus/procfs@v0.13.0...v0.14.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
jritter
pushed a commit
to jritter/procfs
that referenced
this pull request
Jul 15, 2024
As defined in the `torvalds/linux` git tree, `uidgid_types.h`: https://github.com/torvalds/linux/blob/8e938e39866920ddc266898e6ae1fffc5c8f51aa/include/linux/uidgid_types.h#L8 Fixes: prometheus#372 Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As defined in
uidgid_types.h: https://github.com/torvalds/linux/blob/8e938e39866920ddc266898e6ae1fffc5c8f51aa/include/linux/uidgid_types.h#L8 (#372 (comment)).Fixes: #372