sysfs: skip thermal for ENODATA#300
Merged
pgier merged 1 commit intoprometheus:masterfrom May 27, 2020
Merged
Conversation
172f1cd to
9e1b5ca
Compare
discordianfish
approved these changes
May 25, 2020
Member
discordianfish
left a comment
There was a problem hiding this comment.
LGTM.
Not sure why codespell complains but seems unrelated:
./fixtures.ttar:2003: hda ==> had
./cpuinfo_test.go:104: sie ==> size, sigh
./proc_fdinfo.go:44: structed ==> structured
Contributor
|
@SuperQ mentioned in another PR that the version of codespell updated. |
Member
|
Pushed the fix for codespell here: #301 |
9e1b5ca to
29bdec2
Compare
Collaborator
Author
|
Rebased, and the tests seem good now. |
In some cases the value of <thermal_zoneX>/temp will return ENODATA. If this is the case, we should just skip this zone and continue reading the rest of the zones. Fixes prometheus#293 Signed-off-by: Paul Gier <pgier@redhat.com>
29bdec2 to
ea166e0
Compare
remijouannet
pushed a commit
to remijouannet/procfs
that referenced
this pull request
Oct 20, 2022
…data sysfs: skip thermal for ENODATA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases the value of <thermal_zoneX>/temp will return
ENODATA. If this is the case, we should just skip this zone
and continue reading the rest of the zones.
Fixes #293