Make collector-specific flags consistent with others.#47
Merged
Conversation
Member
Author
|
@grobie @brian-brazil @kormat for visibility |
Contributor
There was a problem hiding this comment.
README needs updating too
Contributor
|
👍 |
This puts all collector-specific flags into their own namespace under "collector.<collector-name>", and moves from camel case to dashes, which is the standard in Prometheus land now.
4e5237d to
efcce45
Compare
Member
Author
|
Ah thanks, updated. |
juliusv
added a commit
that referenced
this pull request
Feb 18, 2015
Make collector-specific flags consistent with others.
smarterclayton
pushed a commit
to smarterclayton/node_exporter
that referenced
this pull request
Jan 8, 2020
Dockerfile.ocp: upgrade Go to 1.13
tamcore
pushed a commit
to gitgrave/node_exporter
that referenced
this pull request
Oct 22, 2024
Fix NFS transport stats v1.0 parsing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This puts all collector-specific flags into their own namespace under
"collector.", and moves from camel case to dashes, which
is the standard in Prometheus land now.