Also ignore vda1 and friends#44
Merged
brian-brazil merged 1 commit intoprometheus:masterfrom Feb 18, 2015
Merged
Conversation
Member
|
👍 and ok with also ignoring Btw., just noticing that we're still using camelCase flag names here instead of what we're standardizing on in other components. Just a heads-up, that'll change soon. |
Contributor
|
We'll likely need something a bit better here long term, /dev/xdva1 is the main block device on AWS for example. I think /sys lets you figure out the actual block devices before partitions, rather than us having to fudge it with a regex. |
brian-brazil
added a commit
that referenced
this pull request
Feb 18, 2015
Also ignore vda1 and friends
Contributor
Author
|
@brian-brazil - That would be ideal, yes. It looks like the contents of /sys/block/ would help, as partitions aren't listed. However, you still have loop and devicemapper entries. Damn abstractions not being leaky in just the way you were hoping. |
tamcore
pushed a commit
to gitgrave/node_exporter
that referenced
this pull request
Oct 22, 2024
This removes top level 'New<Thing>' constructor functions in order to make the API slightly smaller and more consistent. Fixes issue prometheus#44 Also includes some minor readme and godoc updates. Signed-off-by: Paul Gier <pgier@redhat.com>
philipgough
pushed a commit
to philipgough/node_exporter
that referenced
this pull request
Jan 8, 2025
upgrade go version to 1.21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whatever virtualization bigv.io use, it exposes block devices as /dev/vda{,1,2}. As we only care about stats for the whole block devices, and not partitions, add vd? partitions to ignore list.
I'm unsure whether we should also ignore /dev/fd? and /dev/sr?. There is a case that the latter might still be useful, but the former is really dubious. Thoughts?
@juliusv @brian-brazil