pressure: Fix missing IRQ on older kernels#3263
Merged
Conversation
5ed7196 to
17e4c71
Compare
jkroepke
approved these changes
Mar 31, 2025
Member
jkroepke
left a comment
There was a problem hiding this comment.
nit: I see new constants. Maybe it make sense to use them between line 120 and 150 as well.
A side from that, LGTM
Fix "no data" error on kernels that support some PSI status, but don't yet have IRQ presure metrics. Only report "no data" error if `pressure` is enabled and no PSI metrics were found. Fixes: #3259 Signed-off-by: Ben Kochie <superq@gmail.com>
17e4c71 to
72ac9eb
Compare
Member
Author
|
Good suggestion on the other const use. |
SuperQ
added a commit
that referenced
this pull request
Apr 1, 2025
Fix "no data" error on kernels that support some PSI status, but don't yet have IRQ presure metrics. Only report "no data" error if `pressure` is enabled and no PSI metrics were found. Fixes: #3259 Signed-off-by: Ben Kochie <superq@gmail.com>
Merged
SuperQ
added a commit
that referenced
this pull request
Apr 1, 2025
* Avoid memory leak by using value rather than reference. (#3277) Signed-off-by: Rolf Klemenz <tickez@madnet.ch> * pressure: Fix missing IRQ on older kernels (#3263) Fix "no data" error on kernels that support some PSI status, but don't yet have IRQ presure metrics. Only report "no data" error if `pressure` is enabled and no PSI metrics were found. Fixes: #3259 Signed-off-by: Ben Kochie <superq@gmail.com> * Release v1.9.1 * [BUGFIX] pressure: Fix missing IRQ on older kernels #3263 * [BUGFIX] Fix Darwin memory leak #3277 Signed-off-by: Ben Kochie <superq@gmail.com> --------- Signed-off-by: Rolf Klemenz <tickez@madnet.ch> Signed-off-by: Ben Kochie <superq@gmail.com> Co-authored-by: Rolf Klemenz <tickez@madnet.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix "no data" error on kernels that support some PSI status, but don't yet have IRQ presure metrics. Only report "no data" error if
pressureis enabled and no PSI metrics were found.Fixes: #3259