Merged
Conversation
8a80711 to
79cc810
Compare
Member
Author
|
👓 @tjhop |
tjhop
suggested changes
Sep 11, 2024
Contributor
tjhop
left a comment
There was a problem hiding this comment.
Looks great to me (aside from the comment about the test fixtures, and the build updates -- unsure if we'd rather separate those bits).
Can we also enable the sloglint linter in golanci-lint? It's disabled by default:
Lines 2 to 5 in b9d0932
| prometheus.Gatherers{h.exporterMetricsRegistry, r}, | ||
| promhttp.HandlerOpts{ | ||
| ErrorLog: stdlog.New(log.NewStdlibAdapter(level.Error(h.logger)), "", 0), | ||
| ErrorLog: slog.NewLogLogger(h.logger.Handler(), slog.LevelError), |
Merged
79cc810 to
63e3c2e
Compare
Switch from promlog/go-kit to promslog/slog for logging. * Update Go build to 1.23. Signed-off-by: Ben Kochie <superq@gmail.com>
63e3c2e to
c1a6f9a
Compare
rexagod
added a commit
to rexagod/node_exporter
that referenced
this pull request
Sep 22, 2024
Sync dependencies and log using the machinery introduced in prometheus#3097. Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod
added a commit
to rexagod/node_exporter
that referenced
this pull request
Sep 22, 2024
Sync dependencies and log using the machinery introduced in prometheus#3097. Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod
added a commit
to rexagod/node_exporter
that referenced
this pull request
Sep 22, 2024
Sync dependencies and log using the machinery introduced in prometheus#3097. Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod
added a commit
to rexagod/node_exporter
that referenced
this pull request
Sep 22, 2024
Sync dependencies and log using the machinery introduced in prometheus#3097. Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod
added a commit
to rexagod/node_exporter
that referenced
this pull request
Sep 22, 2024
Log using the machinery introduced in prometheus#3097. Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
SuperQ
pushed a commit
that referenced
this pull request
Sep 22, 2024
rongyi
pushed a commit
to ontology-tech/node_exporter
that referenced
this pull request
Oct 17, 2024
Switch from promlog/go-kit to promslog/slog for logging. * Update Go build to 1.23. Signed-off-by: Ben Kochie <superq@gmail.com>
rongyi
pushed a commit
to ontology-tech/node_exporter
that referenced
this pull request
Oct 17, 2024
Log using the machinery introduced in prometheus#3097. Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod
added a commit
to rexagod/node_exporter
that referenced
this pull request
Oct 20, 2024
Sync dependencies and log using the machinery introduced in prometheus#3097. Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
v-zhuravlev
pushed a commit
to grafana/node_exporter
that referenced
this pull request
Nov 1, 2024
Switch from promlog/go-kit to promslog/slog for logging. * Update Go build to 1.23. Signed-off-by: Ben Kochie <superq@gmail.com> Signed-off-by: Vitaly Zhuravlev <v-zhuravlev@users.noreply.github.com>
v-zhuravlev
pushed a commit
to grafana/node_exporter
that referenced
this pull request
Nov 1, 2024
Log using the machinery introduced in prometheus#3097. Signed-off-by: Pranshu Srivastava <rexagod@gmail.com> Signed-off-by: Vitaly Zhuravlev <v-zhuravlev@users.noreply.github.com>
rexagod
added a commit
to rexagod/node_exporter
that referenced
this pull request
Nov 27, 2024
Sync dependencies and log using the machinery introduced in prometheus#3097. Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod
added a commit
to rexagod/node_exporter
that referenced
this pull request
Dec 20, 2024
Sync dependencies and log using the machinery introduced in prometheus#3097. Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
discordianfish
pushed a commit
that referenced
this pull request
Dec 23, 2024
Sync dependencies and log using the machinery introduced in #3097. Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
SuperQ
added a commit
that referenced
this pull request
Feb 16, 2025
* [CHANGE] meminfo: Convert linux implementation to use procfs lib #3049 * [CHANGE] Update logging to use Go log/slog #3097 * [FEATURE] filesystem: Add `node_filesystem_mount_info` metric #2970 * [FEATURE] btrfs: Add metrics for commit statistics #3010 * [FEATURE] interrupts: Add collector include/exclude filtering #3028 * [FEATURE] interrupts: Add "exclude zeros" filtering #3028 * [FEATURE] slabinfo: Add filters for slab name. #3041 * [FEATURE] pressure: add IRQ PSI metrics #3048 * [FEATURE] hwmon: Add include and exclude filter for sensors #3072 * [FEATURE] filesystem: Add NetBSD support #3082 * [FEATURE] netdev: Add ifAlias label #3087 * [FEATURE] hwmon: Add Support for GPU Clock Frequencies #3093 * [FEATURE] Add `exclude[]` URL parameter #3116 * [FEATURE] Add AIX support #3136 * [FEATURE] filesystem: Add fs-types/mount-points include flags #3171 * [FEATURE] netstat: Add collector for tcp packet counters for FreeBSD. #3177 * [ENHANCEMENT] ethtool: Add logging for filtering flags #2979 * [ENHANCEMENT] netstat: Add TCPRcvQDrop to default metrics #3021 * [ENHANCEMENT] diskstats: Add block device rotational #3022 * [ENHANCEMENT] cpu: Support CPU online status #3032 * [ENHANCEMENT] arp: optimize interface name resolution #3133 * [ENHANCEMENT] textfile: Allow specifiying multiple directory globs #3135 * [ENHANCEMENT] filesystem: Add reporting of purgeable space on MacOS #3206 * [ENHANCEMENT] ethtool: Skip full scan of NetClass directories #3239 * [BUGFIX] zfs: Prevent `procfs` integer underflow #2961 * [BUGFIX] pressure: Fix collection on systems that do not expose a full CPU stat #3054 * [BUGFIX] cpu: Fix FreeBSD 32-bit host support and plug memory leak #3083 * [BUGFIX] hwmon: Add safety check to hwmon read #3134 * [BUGFIX] zfs: Allow space in dataset name #3186 Signed-off-by: Ben Kochie <superq@gmail.com>
Merged
SuperQ
added a commit
that referenced
this pull request
Feb 17, 2025
* [CHANGE] meminfo: Convert linux implementation to use procfs lib #3049 * [CHANGE] Update logging to use Go log/slog #3097 * [FEATURE] filesystem: Add `node_filesystem_mount_info` metric #2970 * [FEATURE] btrfs: Add metrics for commit statistics #3010 * [FEATURE] interrupts: Add collector include/exclude filtering #3028 * [FEATURE] interrupts: Add "exclude zeros" filtering #3028 * [FEATURE] slabinfo: Add filters for slab name. #3041 * [FEATURE] pressure: add IRQ PSI metrics #3048 * [FEATURE] hwmon: Add include and exclude filter for sensors #3072 * [FEATURE] filesystem: Add NetBSD support #3082 * [FEATURE] netdev: Add ifAlias label #3087 * [FEATURE] hwmon: Add Support for GPU Clock Frequencies #3093 * [FEATURE] Add `exclude[]` URL parameter #3116 * [FEATURE] Add AIX support #3136 * [FEATURE] filesystem: Add fs-types/mount-points include flags #3171 * [FEATURE] netstat: Add collector for tcp packet counters for FreeBSD. #3177 * [ENHANCEMENT] ethtool: Add logging for filtering flags #2979 * [ENHANCEMENT] netstat: Add TCPRcvQDrop to default metrics #3021 * [ENHANCEMENT] diskstats: Add block device rotational #3022 * [ENHANCEMENT] cpu: Support CPU online status #3032 * [ENHANCEMENT] arp: optimize interface name resolution #3133 * [ENHANCEMENT] textfile: Allow specifiying multiple directory globs #3135 * [ENHANCEMENT] filesystem: Add reporting of purgeable space on MacOS #3206 * [ENHANCEMENT] ethtool: Skip full scan of NetClass directories #3239 * [BUGFIX] zfs: Prevent `procfs` integer underflow #2961 * [BUGFIX] pressure: Fix collection on systems that do not expose a full CPU stat #3054 * [BUGFIX] cpu: Fix FreeBSD 32-bit host support and plug memory leak #3083 * [BUGFIX] hwmon: Add safety check to hwmon read #3134 * [BUGFIX] zfs: Allow space in dataset name #3186 Signed-off-by: Ben Kochie <superq@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch from promlog/go-kit to promslog/slog for logging.